chore(apple): Remove managed enforcement of full-tunnel - #9230
Merged
Conversation
jamilbk
requested review from
Copilot and
thomaseizinger
and removed request for
Copilot
May 26, 2025 03:34
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes all occurrences of the managed (forced) enforcement of full-tunnel behavior in favor of policy-based management.
- Removed the "forced" property and its related CombineLatest subscriptions from ResourceView.
- Removed forced state handling, UI disabling, and related comparisons from MenuBar.
- Updated default settings and conditional checks in Configuration and Store to reflect the change.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| swift/apple/FirezoneKit/Sources/FirezoneKit/Views/ResourceView.swift | Removed forced state property and simplified CombineLatest to only observe enabled state. |
| swift/apple/FirezoneKit/Sources/FirezoneKit/Views/MenuBar.swift | Removed forced state UI handling and related state comparisons. |
| swift/apple/FirezoneKit/Sources/FirezoneKit/Stores/Store.swift | Updated boolean check for connectOnStart for stylistic consistency. |
| swift/apple/FirezoneKit/Sources/FirezoneKit/Models/Configuration.swift | Removed forced state properties and updated default values accordingly. |
Comments suppressed due to low confidence (3)
swift/apple/FirezoneKit/Sources/FirezoneKit/Views/ResourceView.swift:239
- The removal of the 'forced' property is consistent with the change; please ensure that all UI elements previously relying on the forced state are updated and that tests cover these changes.
@Published private(set) var forced: Bool
swift/apple/FirezoneKit/Sources/FirezoneKit/Views/MenuBar.swift:277
- [nitpick] Removing the disabling logic based on 'forced' is intentional; double-check that the new behavior aligns with design expectations without unintentionally allowing modifications where managed settings were expected.
.disabled(viewModel.forced)
swift/apple/FirezoneKit/Sources/FirezoneKit/Models/Configuration.swift:115
- [nitpick] The removal of forced state updates in Configuration is appropriate for this change; ensure that associated documentation and tests are updated to reflect the new behavior.
self.publishedInternetResourceForced = isInternetResourceForced
| static let defaultSupportURL = "https://firezone.dev/support" | ||
|
|
||
| // Bools are always default false | ||
| static let defaultConnectOnStart = false |
There was a problem hiding this comment.
Changing the defaultConnectOnStart value from true to false affects startup behavior; please document this change clearly in release notes or migration guides.
thomaseizinger
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After discussing with @thomaseizinger, we realized this is better supported with Polices.