fix(apple): Don't throw when quitting with a stopped tunnel#9231
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the stop() method in IPCClient to no longer require a connected tunnel state before calling stopTunnel, preventing an error when quitting with an already stopped tunnel.
- Removed the status filter (
.connected, .connecting, .reasserting) fromsession()instop() - Now always calls
session().stopTunnel()as a no-op if the tunnel is already down
Comments suppressed due to low confidence (1)
swift/apple/FirezoneKit/Sources/FirezoneKit/Helpers/IPCClient.swift:71
- There's no existing test verifying
stop()behavior when the tunnel is already stopped. Consider adding a unit test to confirm it no-ops without throwing in this scenario.
try session().stopTunnel()
| @@ -68,7 +68,7 @@ class IPCClient { | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
[nitpick] Consider updating the doc comment for stop() to explain that it no longer requires a connected tunnel and will no-op if the tunnel is already stopped.
Suggested change
| /// Stops the tunnel connection. | |
| /// | |
| /// This method no longer requires a connected tunnel and will no-op if the tunnel is already stopped. |
thomaseizinger
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the tunnel is already down when we try to quit the application, we were throwing a harmless error because we mistakenly required a connected status to send the
stopTunnelcommand, which is just a no-op if we're already connected.