feat(gui-client): introduce "General" settings page#9381
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the settings UI in the GUI client by introducing a new "General" settings page and splitting the previous settings page into two distinct sections (General and Advanced). Key changes include:
- Adding a new GeneralSettingsForm and related Tauri command to apply general settings.
- Updating the settings model and view model in Rust and TypeScript to support the new general settings.
- Adjusting the GUI navigation, sidebar, and controller logic to differentiate between advanced and general settings.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rust/gui-client/src-tauri/src/view.rs | Adds GeneralSettingsForm and a new Tauri command for general settings. |
| rust/gui-client/src-tauri/src/settings.rs | Introduces new fields and view model for general settings. |
| rust/gui-client/src-tauri/src/gui/os_windows.rs | Implements autostart functionality via Windows Registry. |
| rust/gui-client/src-tauri/src/gui.rs | Updates GUI events and navigation to handle separate settings pages. |
| rust/gui-client/src-tauri/src/controller.rs | Adds support for applying and persisting general settings. |
| rust/gui-client/src-frontend/main.tsx | Updates sidebar navigation and route configuration for new settings pages. |
| rust/gui-client/src-frontend/components/ManagedInput.tsx | Provides managed input wrappers for controlled UI components. |
| rust/gui-client/src-frontend/components/GeneralSettingsPage.tsx | Implements the new UI for general settings. |
| rust/gui-client/src-frontend/components/AdvancedSettingsPage.tsx | Adjusts the advanced settings page to integrate into the new structure. |
thomaseizinger
force-pushed
the
feat/general-settings
branch
from
a68968d to
7eeafb7
Compare
jamilbk
left a comment
jamilbk
left a comment
There was a problem hiding this comment.
Couple comments re: form ordering/styling, will take a deeper look again in a bit
jamilbk
force-pushed
the
feat/general-settings
branch
from
ea01683 to
16e9932
Compare
|
Noooo I rebased to fix the CI and ended up with more problems 🙃 |
jamilbk
force-pushed
the
feat/general-settings
branch
from
9d64050 to
f738459
Compare
|
@thomaseizinger I pushed a change blind 🙈 - spent a bit of time trying to get the frontend to load on macOS to no avail 😆. Open to syncing up to close this one out. The new UI looks really nice overall! |
|
|
I can fix up the Rust comments :) |
|
I noticed the generated HTML uses a font URL as opposed to embedded font file. Any idea if that might not load if this window is opened without internet connectivity? |
I would assume this to be cached but I never tested it. |
|
Ready to go in from my PoV. |
See #9398 |
This PR introduces "General" settings for the GUI client. The "Settings" menu item in the GUI is split into two sub-sections. The menu item is collapsible but open by default.
"Connect on start" and "Account slug" can both be MDM managed. The autostart functionality is implemented via the Windows Registry.