Repository navigation
fix(gui-client): fix minor frontend issues in app window - #9505
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
|
I've tested this with |
jamilbk
force-pushed
the
fix/cursor-pointer
branch
from
June 11, 2025 02:12
e5f3fd3 to
9ff8559
Compare
jamilbk
changed the title
jamilbk
force-pushed
the
fix/cursor-pointer
branch
from
June 11, 2025 02:52
9ff8559 to
26c5a3d
Compare
bmanifold
approved these changes
Jun 11, 2025
thomaseizinger
approved these changes
Jun 11, 2025
| logsRecountedUnlisten.then((unlistenFn) => unlistenFn()); | ||
| }; | ||
| }, []); | ||
| }, [location, handleClick]); |
Member
There was a problem hiding this comment.
Why are these dependencies of useEffect? You are not using them in the effect handler so that should not be necessary?
| active={location.pathname.startsWith("/advanced-settings")} | ||
| icon={WrenchScrewdriverIcon} | ||
| href="/advanced-settings" | ||
| onClick={handleClick} |
Member
There was a problem hiding this comment.
It appears to me that a better abstraction would be if we had our own ReactRouterSidebarItem component that uses the two hooks internally and checks if its href is in the pathname. Then we'd only need to pass icon and href and children to each component.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 15, 2025
This cleans up some changes left over from #9505 by using a custom component.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NavLinkin favor of using thehrefprop onSidebarItem. This fixes vertical spacing between sidebar items (it was inconsistent) and DOM structure issues caused by settingNavLinkas a direct child of<SidebarItemGroup>.cursor-pointerto all<Button>scursor-pointerto the<SidebarCollapse>Before
After