makeImage.sh with a wrong DEVICE variable value causes error #89
Comments
Thanks for the feedback. Can you submit it as a pull request? My only concern is that other scripts such as |
c0mix
added a commit
to c0mix/firmadyne
that referenced
this issue
Sep 18, 2018
As suggested I've opened a pull request here #90 moving the parsing into |
ddcc
added a commit
that referenced
this issue
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Inside firmadyne.config, the below assumption is not always correct.
This wrong assumption causes a failure during the mounting phase of
makeImage.sh
becauseget_device
it is called by the script to set DEVICE variable (line 51).To avoid this issue, a simple workaround could be applied inside makeImage.sh file, specifically, it is possible to use the output of the kpartx command to infer the correct device name and set DEVICE variable.
The fixed makeImage.sh should look like this:
https://gist.github.com/c0mix/085a350df0b78290d3b3fb175a5c5555
Note: Tested on ubuntu 18.04 with 4.15.0-34-generic
The text was updated successfully, but these errors were encountered: