makeImage.sh with a wrong DEVICE variable value causes error

[c0mix]

Inside firmadyne.config, the below assumption is not always correct.

get_device () {
    echo "/dev/mapper/loop0p1"
}

This wrong assumption causes a failure during the mounting phase of makeImage.sh because get_device it is called by the script to set DEVICE variable (line 51).

DEVICE=`get_device`

To avoid this issue, a simple workaround could be applied inside makeImage.sh file, specifically, it is possible to use the output of the kpartx command to infer the correct device name and set DEVICE variable.

echo "----Mounting QEMU Image----"
output=$(kpartx -a -s -v "${IMAGE}")
foo=$(echo "$output" | cut -d ' ' -f 3)
DEVICE="/dev/mapper/$foo"
echo $DEVICE # for debug purpose (can be removed)
sleep 1

The fixed makeImage.sh should look like this:
https://gist.github.com/c0mix/085a350df0b78290d3b3fb175a5c5555
Note: Tested on ubuntu 18.04 with 4.15.0-34-generic

[ddcc]

Thanks for the feedback. Can you submit it as a pull request? My only concern is that other scripts such as mount.sh also utilize this functionality, so it'd be better to move the parsing into the firmadyne.config script, and have get_device take the output of kpartx as an input argument.

[c0mix]

As suggested I've opened a pull request here #90 moving the parsing into firmadyne.config
I hope that this will help you to improve your fantastic tool :)