sguil: fix recursive calling of SguilSensorAgentInit #56

Merged
merged 1 commit into from Jan 18, 2013

Conversation

Projects
None yet
3 participants
Contributor

inliniac commented Dec 3, 2012

Recursive function calling is leading to stack exhaustion on connection problems. Saw this on my local sensors.

Change simply removes the recursive calling. There seem to be a few other places where recursive functions are called in the spo_sguil.c module btw.

Collaborator

binf commented Dec 3, 2012

Bha lets blame bamm and firnsy.

Each output plugin will get a rewrite in their time due :)

Collaborator

binf commented Dec 4, 2012

Just to update this after talking with firnsy, he inherited the plugin.
We will look into this asap VJ.

Collaborator

binf commented Dec 4, 2012

I spend a quick minute looking at this and i think that the "recusrivity" is intended but it should bail after N time, there is unfortunatly no check on sguil_agent_setup_timeouts so that could be the issue what do you guys think?

Contributor

inliniac commented Dec 5, 2012

If we add a bail after x failed attempts I still think the call shouldn't be recursive. I'd like a unlimited option as well, my server is slow and overloaded for long times so I'd have it retry forever.

firnsy added a commit that referenced this pull request Jan 18, 2013

Merge pull request #56 from inliniac/sguil-timeout-fix
sguil: fix recursive calling of SguilSensorAgentInit

@firnsy firnsy merged commit fec25ae into firnsy:master Jan 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment