No description provided.
Added a default config to allow shared and custom configs
interesting. what's the use case?
lots of duplicate code here. I would think there should be a single function that takes the directory and returns the full object. Then you just do the merge at the end
Primarily for boilerplate solutions like the Ember App Kit, I needed a way to separate the grunt options given in the app kit from my own customisations. This separation is needed when we need to update the app kit and I need to maintain my own customisations.
Reg code duplication, will clean up and push later today.
Sounds good. I think it should be called configDir and customConfigDir. Also, make sure to add tests
I left configPath as it is and added a defaultPath to maintain backwards compatibility, as a lot of projects might already be using this. Also, I think of it more so of allowing an optional default rather than an optional customizable config, if that makes any sense.
Refactor fetching settings and merge later. Added test
I've separated out the simplemocha config as an example on how to set this up. Any suggestions on how to do this (and test this) better?
anything else to be done here?
It looks like I can't auto merge anymore. Can you look into that? Then I'll merge this in.
Merge remote-tracking branch 'upstream/master' into separate-default-…
Merged the latest changes and tested it.
k. will merge this in today. I'm going to separate the grunt register part from the actual logic so it's easier to test this.
Revert "Merge pull request #16 from Pradeek/separate-default-config"
This reverts commit 2068d8f, reversing
changes made to 9a69976.
I reverted this because I'm going to do some refactoring and bring this back in later. might take me a day or so