You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
completion for gradle wrapper doesn't work properly #10127
Hi @faho, thanks for this.
I tried your fix locally (by creating the gradlew.fish file in /usr/share/fish/completions) and it still doesn't work. Did you test that commit? Does it work for you?
Same thing here. It doesn't work for me either.
The workaround helps, but it also seems that it doesn't show any project names, only CLI flags when typing ./gradlew --<TAB>.
fish won't load completions for commands it can't find via $PATH (#9133)
If I understand that correctly, then it's a bigger bug that needs fixing:
I'm in a directory that contains a shell script ./gradlew
the script is executable
I'm typing ./gradlew {TAB}
I'm not getting completions because ./gradlew is not in $PATH. But this is completely wrong. I should get completion every time I can execute that command correctly and that includes (1) being in $PATH, (2) having a correct relative path (this case); (3) having a correct absolute path.
Activity
faho commentedon Nov 29, 2023
Fixed by 180692f, to be released in 3.7.0.
cvmocanu commentedon Nov 29, 2023
Hi @faho, thanks for this.
I tried your fix locally (by creating the
gradlew.fishfile in/usr/share/fish/completions) and it still doesn't work. Did you test that commit? Does it work for you?jvican commentedon Dec 2, 2023
Same thing here. It doesn't work for me either.
The workaround helps, but it also seems that it doesn't show any project names, only CLI flags when typing
./gradlew --<TAB>.faho commentedon Dec 2, 2023
What you're seeing here is that fish won't load completions for commands it can't find via $PATH (#9133).
This is because it wouldn't use the relative path you're using if the completions called just e.g.
gradle(#3117), and would then error out.It appears neither of you has gradle installed globally, and you rely on running it via
./gradle, which unfortunately hits this case.What you can do in that case is to eagerly load the completion -
source /usr/share/fish/completions/gradle.fish.cvmocanu commentedon Dec 4, 2023
If I understand that correctly, then it's a bigger bug that needs fixing:
./gradlew./gradlew {TAB}./gradlewis not in $PATH. But this is completely wrong. I should get completion every time I can execute that command correctly and that includes (1) being in $PATH, (2) having a correct relative path (this case); (3) having a correct absolute path.faho commentedon Dec 4, 2023
Yes, it is #3117