Commandline is needlessly repainted with new extended keyboard input functionality

[zx8]

Using 3af849d and iTerm 2 (v3.4.23)

This used to work prior to the new extended keyboard input functionality, so I suspect it is related.

---

Define the following fish_prompt:

function fish_prompt
  echo -e '---\n$ '
end

Define the following function to be bound:

function nextdir-or-forward-word
    set -l cmd (commandline)
    if test -z "$cmd"
        nextd
        commandline -f repaint
    else
        commandline -f forward-word
    end
end

Bind it:

bind alt-right nextdir-or-forward-word

Use it:

[zx8]

@krobelus This seems to have regressed(?) since 8a7c3ce.

It is now happening again(?) with 64bc989, albeit slightly differently than originally described in the initial issue.

I can no longer reproduce with the echo a/b/c/d/e example, but I can reproduce if I recall a command from history, like so:

[krobelus]

thanks, fixed in 1da2087

[zanchey]

Do we need a test for this?

[krobelus]

Yeah a test would be good. At least on macOS it reproduces consistently, maybe even on BSD.
The implementation is very dated here, needs a proper cleanup.