-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commandline is needlessly repainted with new extended keyboard input functionality #10409
Labels
regression
Something that used to work, but was broken, especially between releases
Milestone
Comments
krobelus
added a commit
that referenced
this issue
Apr 9, 2024
As mentioned in 8a7c3ce (Don't abandon line after writing control sequences, 2024-04-06) we need to freshed stdout timestamps after writing to stdout but before we might redraw, in particular when writing control sequences. Commit a583fe7 ("commandline -f foo" to skip queue and execute immediately, 2024-04-08) made "commandline -f repaint" redraw immediately, while still executing the bound shell command; at that time we have written "disabling" sequences but not refreshed timestamps yet, so do that. This is probably not needed for commands outside the repaint family. Needless to say that this is messy, maybe we can simplify things in future. Ref #10409 (comment)
thanks, fixed in 1da2087 |
Do we need a test for this? |
Yeah a test would be good. At least on macOS it reproduces consistently, maybe even on BSD. |
vertesians
pushed a commit
to vertesians/fish-shell
that referenced
this issue
Apr 17, 2024
As mentioned in 8a7c3ce (Don't abandon line after writing control sequences, 2024-04-06) we need to freshed stdout timestamps after writing to stdout but before we might redraw, in particular when writing control sequences. Commit a583fe7 ("commandline -f foo" to skip queue and execute immediately, 2024-04-08) made "commandline -f repaint" redraw immediately, while still executing the bound shell command; at that time we have written "disabling" sequences but not refreshed timestamps yet, so do that. This is probably not needed for commands outside the repaint family. Needless to say that this is messy, maybe we can simplify things in future. Ref fish-shell#10409 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using 3af849d and iTerm 2 (v3.4.23)
This used to work prior to the new extended keyboard input functionality, so I suspect it is related.
Define the following
fish_prompt
:Define the following function to be bound:
Bind it:
Use it:
The text was updated successfully, but these errors were encountered: