Wezterm: can't see digits if the shift key is down

[robey]

This sounds totally weird, but... in my keyboard layout (coder-dvorak), the digit keys are on the shift layer. To get "4", I hold down shift and press the "4" key.

Using wezterm + fish 4, digits are "eaten" somewhere and never make it to the shell. Turning on set -Ua fish_features no-keyboard-protocols works around the bug (digits work again).

Happy to test out potential fixes in a local git checkout if that helps.

[faho]

It's a known bug in Wezterm.

The kitty keyboard protocol there is broken with keyboard layouts other than qwerty and modifiers.

Since it's off by default we decided not to work around it so qwerty users can try.

[krobelus]

Note that wezterm disables kitty keyboard protocol by default (perhaps for this reason?),
so I recommend you remove enable_kitty_keyboard from your WezTerm config file.

[robey]

Note that wezterm disables kitty keyboard protocol by default (perhaps for this reason?), so I recommend you remove enable_kitty_keyboard from your WezTerm config file.

Must be on by default, because it's not in my config file, but the fish command above was a fine workaround until they get a proper fix in wezterm. Thanks for the help!

[faho]

I just downloaded the latest release and it appears to be off. Maybe you're using a nightly build and it's on there?

[krobelus]

It's because modifyOtherKeys is broken in WezTerm too (and enableable by default).

Since this is a default config we can add this workaround.
Unfortunately it doesn't work inside SSH (this is the type of scenario where XTVERSION will come in handy)

diff --git a/src/input_common.rs b/src/input_common.rs
index 879d082d8a..0ed2570a2b 100644
--- a/src/input_common.rs
+++ b/src/input_common.rs
@@ -437,6 +437,7 @@ pub static IN_MIDNIGHT_COMMANDER_PRE_CSI_U: RelaxedAtomicBool = RelaxedAtomicBoo
 static IN_ITERM_PRE_CSI_U: RelaxedAtomicBool = RelaxedAtomicBool::new(false);
 static IN_JETBRAINS: RelaxedAtomicBool = RelaxedAtomicBool::new(false);
 static IN_KITTY: RelaxedAtomicBool = RelaxedAtomicBool::new(false);
+static IN_WEZTERM: RelaxedAtomicBool = RelaxedAtomicBool::new(false);
 
 pub fn terminal_protocol_hacks() {
     use std::env::var_os;
@@ -457,6 +458,10 @@ pub fn terminal_protocol_hacks() {
     );
     IN_KITTY
         .store(var_os("TERM").is_some_and(|term| term.as_os_str().as_bytes() == b"xterm-kitty"));
+    IN_WEZTERM.store(
+        var_os("TERM_PROGRAM")
+            .is_some_and(|term_program| term_program.as_os_str().as_bytes() == b"WezTerm"),
+    );
 }
 
 fn parse_version(version: &wstr) -> Option<(i64, i64, i64)> {
@@ -491,7 +496,7 @@ pub fn terminal_protocols_enable_ifn() {
         // Jetbrains IDE terminals vomit CSI u
         // iTerm fails to option-modify keys
         concat!("\x1b[?2004h", "\x1b[>4;1m", "\x1b=",)
-    } else if IN_KITTY.load() {
+    } else if IN_KITTY.load() || IN_WEZTERM.load() {
         // Kitty spams the log for modifyotherkeys
         concat!(
             "\x1b[?2004h", // Bracketed paste
@@ -524,7 +529,7 @@ pub(crate) fn terminal_protocols_disable_ifn() {
         concat!("\x1b[?2004l", "\x1b[>4;0m", "\x1b>",)
     } else if IN_JETBRAINS.load() {
         concat!("\x1b[?2004l", "\x1b[>4;0m", "\x1b>",)
-    } else if IN_KITTY.load() {
+    } else if IN_KITTY.load() || IN_WEZTERM.load() {
         // Kitty spams the log for modifyotherkeys
         concat!(
             "\x1b[?2004l", // Bracketed paste

[faho]

It's because modifyOtherKeys is broken in WezTerm too (and enableable by default).

Do you actually see that? I don't. I run fish_key_reader from 4.0 in an entirely unconfigured wezterm, and press shift-something, and I see the correct old-school key encodings. No shift-', no shift-3.

[krobelus]

yes, I used us layout with dvp (dvorak-programmer) variant.
(Though this layout is generally broken because the numbers are out of order)
Pressing 4 and Shift-4 gives

$ wezterm -e $PWD/target/debug/fish_key_reader -cV
bind \} 'do something'
# decoded from: \e\[27\;2\;51\~
bind shift-3 'do something'

the 27;2;51 is the default output format of modifyOtherKeys (WezTerm can be configured to use CSI u also)

[faho]

Okay, disabling modifyOtherKeys there is the way to go then.