Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sshfs completions assume ~/mnt exists #1268

Closed
mistydemeo opened this issue Jan 27, 2014 · 2 comments
Closed

sshfs completions assume ~/mnt exists #1268

mistydemeo opened this issue Jan 27, 2014 · 2 comments
Assignees
Milestone

Comments

@mistydemeo
Copy link
Contributor

@mistydemeo mistydemeo commented Jan 27, 2014

The sshfs completion assumes that a directory named ~/mnt exists, resulting in pretty messy output if it doesn't. The line in question is here: https://github.com/fish-shell/fish-shell/blob/master/share/completions/sshfs.fish#L20

If I try to tab after typing sshfs, if no ~/mnt exists, this happens:

$ sshfs find: /Users/mistydemeo/mnt: No such file or directory
$ sshfs

That line from completions should probably at least silence stderr if it exists, if it needs to assume ~/mnt exists. Since that's not a mandatory path for sshfs, though, maybe it's better that the default completions shipped with fish don't assume any path.

@zanchey
Copy link
Member

@zanchey zanchey commented Jan 28, 2014

There's no good reason to use ~/mnt.

@zanchey zanchey closed this in 8490aac Jan 29, 2014
@zanchey
Copy link
Member

@zanchey zanchey commented Jan 29, 2014

This should be fixed with 8490aac; please re-open if you are still having problems. Thanks for your contribution!

@ghost ghost assigned zanchey Jan 29, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.