sshfs completions assume ~/mnt exists #1268

Closed
mistydemeo opened this Issue Jan 27, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@mistydemeo
Contributor

mistydemeo commented Jan 27, 2014

The sshfs completion assumes that a directory named ~/mnt exists, resulting in pretty messy output if it doesn't. The line in question is here: https://github.com/fish-shell/fish-shell/blob/master/share/completions/sshfs.fish#L20

If I try to tab after typing sshfs, if no ~/mnt exists, this happens:

$ sshfs find: /Users/mistydemeo/mnt: No such file or directory
$ sshfs

That line from completions should probably at least silence stderr if it exists, if it needs to assume ~/mnt exists. Since that's not a mandatory path for sshfs, though, maybe it's better that the default completions shipped with fish don't assume any path.

@zanchey

This comment has been minimized.

Show comment
Hide comment
@zanchey

zanchey Jan 28, 2014

Member

There's no good reason to use ~/mnt.

Member

zanchey commented Jan 28, 2014

There's no good reason to use ~/mnt.

@zanchey zanchey closed this in 8490aac Jan 29, 2014

@zanchey

This comment has been minimized.

Show comment
Hide comment
@zanchey

zanchey Jan 29, 2014

Member

This should be fixed with 8490aac; please re-open if you are still having problems. Thanks for your contribution!

Member

zanchey commented Jan 29, 2014

This should be fixed with 8490aac; please re-open if you are still having problems. Thanks for your contribution!

@ghost ghost assigned zanchey Jan 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment