New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing Terminal.app window doesn't terminate active SSH session #138

Closed
yunzheng opened this Issue Jun 16, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@yunzheng

yunzheng commented Jun 16, 2012

When using fish as the shell and then "ssh" to a remote machine using 'ssh' and exit the Terminal window (using command+w), the "ssh" process keeps running.

This is not the case when I use /bin/bash (default) as the shell.

Steps to reproduce:

  1. Open Terminal window (with fish as the shell)
  2. ssh [IP]
  3. Close the window using command+w
  4. Open a new Terminal window and check that your ssh session is still open (eg: ps auxww | grep ssh)
@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Jul 15, 2012

Member

Reproduces for me in OS X.

fish only delivers SIGHUP to its children if stdin is closed. I don't know why. Let's make it deliver SIGHUP more often.

Member

ridiculousfish commented Jul 15, 2012

Reproduces for me in OS X.

fish only delivers SIGHUP to its children if stdin is closed. I don't know why. Let's make it deliver SIGHUP more often.

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Jul 15, 2012

Member

Fixed with commit 4755c5f

Member

ridiculousfish commented Jul 15, 2012

Fixed with commit 4755c5f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment