Suggested completion should not word wrap #167

Closed
kballard opened this Issue Jun 21, 2012 · 5 comments

Comments

Projects
None yet
2 participants
@kballard
Contributor

kballard commented Jun 21, 2012

When fish shows me the suggested completion for what I've already typed, it shouldn't word-wrap this completion. The word wrapping can cause it to flicker between having me type on the first line and having the word I'm typing be wrapped onto the second, based on the current suggested autocomplete. Instead, it should character-wrap the suggested autocomplete (or at least the first word of it) and only word wrap actual typed text.

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Jul 12, 2012

Member

The best I've been able to do was committed as f8b4c1b.

Member

ridiculousfish commented Jul 12, 2012

The best I've been able to do was committed as f8b4c1b.

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Jul 12, 2012

Member

What I did was made it append an ellipsis for the autosuggestion (and not wrap at all).

Member

ridiculousfish commented Jul 12, 2012

What I did was made it append an ellipsis for the autosuggestion (and not wrap at all).

@kballard

This comment has been minimized.

Show comment
Hide comment
@kballard

kballard Jul 14, 2012

Contributor

Awesome, that should be good enough. Thanks!

Contributor

kballard commented Jul 14, 2012

Awesome, that should be good enough. Thanks!

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Jul 14, 2012

Member

This is working well in OS X...not so well in Linux.

Member

ridiculousfish commented Jul 14, 2012

This is working well in OS X...not so well in Linux.

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Jul 14, 2012

Member

Never mind, I was testing on an old version in Linux - it works well there too.

Member

ridiculousfish commented Jul 14, 2012

Never mind, I was testing on an old version in Linux - it works well there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment