Fishd exits on startup #1690

Closed
tiffany352 opened this Issue Sep 18, 2014 · 8 comments

Comments

Projects
None yet
3 participants
@tiffany352
~ > fishd
fishd: Connect to socket at /run/user/1000/fishd.socket
fishd: Socket already exists, exiting
fishd: No more clients. Quitting
fishd: Could not remove legacy socket path
unlink: No such file or directory

If I delete /run/user/1000/fishd.socket and the file put into .config/fish/

~ > fishd
fishd: Connect to socket at /run/user/1000/fishd.socket
fishd: Could not create legacy socket path
link: Invalid cross-device link
fishd: Parent process exiting (This is normal)

The first completion I try (not further completions) after restarting fishd prints this:

fishd: No more clients. Quitting
fishd: Could not remove legacy socket path
unlink: No such file or directory

I tried looking for a verbosity option, and using strace. It looks like fishd is trying to create a hard link between /tmp (which is an in-memory filesystem) and /run (which is on SDA1). I don't know why it's suddenly trying to do this, it was working fine before. I last updated fish on September 13th. Here's the full strace output: http://sprunge.us/ZTRN

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Sep 18, 2014

Member

Yikes? Maybe the 2.1.1 changes?

How did you update fish and what does echo $FISH_VERSION show?

Member

ridiculousfish commented Sep 18, 2014

Yikes? Maybe the 2.1.1 changes?

How did you update fish and what does echo $FISH_VERSION show?

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Sep 18, 2014

Member

Also, is the symptom that fishd exits immediately if you run it manually? This is expected if another fishd is running.

Member

ridiculousfish commented Sep 18, 2014

Also, is the symptom that fishd exits immediately if you run it manually? This is expected if another fishd is running.

@zanchey

This comment has been minimized.

Show comment
Hide comment
@zanchey

zanchey Sep 19, 2014

Member

The 2.1.1 changes do attempt to create a hardlink, but failing should not interrupt the operation of fishd. My guess is that you are running Fedora, which has been shipping prerelease patches.

You shouldn't need to start fishd manually - do universal variables work without it?

Member

zanchey commented Sep 19, 2014

The 2.1.1 changes do attempt to create a hardlink, but failing should not interrupt the operation of fishd. My guess is that you are running Fedora, which has been shipping prerelease patches.

You shouldn't need to start fishd manually - do universal variables work without it?

@zanchey

This comment has been minimized.

Show comment
Hide comment
@zanchey

zanchey Sep 22, 2014

Member

I've tested the Fedora-shipped version of fish, and yes - this does happen if you run fishd manually. I think we're running into #1084 as fishd tests if the socket is open, connects to it, then quits, and sometimes gets SIGPIPE.

I'd like to take de8bae3 for 2.1.1 as well - do you think that's reasonable?

Making releases is hard.

Member

zanchey commented Sep 22, 2014

I've tested the Fedora-shipped version of fish, and yes - this does happen if you run fishd manually. I think we're running into #1084 as fishd tests if the socket is open, connects to it, then quits, and sometimes gets SIGPIPE.

I'd like to take de8bae3 for 2.1.1 as well - do you think that's reasonable?

Making releases is hard.

@zanchey

This comment has been minimized.

Show comment
Hide comment
@zanchey

zanchey Sep 22, 2014

Member

Note that the behaviour exists in 2.1.0, so it may not be worth it.

Member

zanchey commented Sep 22, 2014

Note that the behaviour exists in 2.1.0, so it may not be worth it.

@zanchey

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Sep 24, 2014

Member

That has some user-visible symptoms so it seems like a nice fix to take. I'm OK if you want to add it.

Member

ridiculousfish commented Sep 24, 2014

That has some user-visible symptoms so it seems like a nice fix to take. I'm OK if you want to add it.

@zanchey zanchey added this to the 2.1.1 milestone Sep 24, 2014

@zanchey zanchey self-assigned this Sep 24, 2014

@zanchey zanchey added the duplicate label Sep 24, 2014

@zanchey

This comment has been minimized.

Show comment
Hide comment
@zanchey

zanchey Sep 25, 2014

Member

Cherry-picked as 0986b6d and retagged.

Member

zanchey commented Sep 25, 2014

Cherry-picked as 0986b6d and retagged.

@zanchey zanchey closed this Sep 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment