Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fishd exits on startup #1690

Closed
tiffany352 opened this issue Sep 18, 2014 · 8 comments
Closed

Fishd exits on startup #1690

tiffany352 opened this issue Sep 18, 2014 · 8 comments
Assignees
Labels
Milestone

Comments

@tiffany352
Copy link

@tiffany352 tiffany352 commented Sep 18, 2014

~ > fishd
fishd: Connect to socket at /run/user/1000/fishd.socket
fishd: Socket already exists, exiting
fishd: No more clients. Quitting
fishd: Could not remove legacy socket path
unlink: No such file or directory

If I delete /run/user/1000/fishd.socket and the file put into .config/fish/

~ > fishd
fishd: Connect to socket at /run/user/1000/fishd.socket
fishd: Could not create legacy socket path
link: Invalid cross-device link
fishd: Parent process exiting (This is normal)

The first completion I try (not further completions) after restarting fishd prints this:

fishd: No more clients. Quitting
fishd: Could not remove legacy socket path
unlink: No such file or directory

I tried looking for a verbosity option, and using strace. It looks like fishd is trying to create a hard link between /tmp (which is an in-memory filesystem) and /run (which is on SDA1). I don't know why it's suddenly trying to do this, it was working fine before. I last updated fish on September 13th. Here's the full strace output: http://sprunge.us/ZTRN

@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Sep 18, 2014

Yikes? Maybe the 2.1.1 changes?

How did you update fish and what does echo $FISH_VERSION show?

@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Sep 18, 2014

Also, is the symptom that fishd exits immediately if you run it manually? This is expected if another fishd is running.

@zanchey
Copy link
Member

@zanchey zanchey commented Sep 19, 2014

The 2.1.1 changes do attempt to create a hardlink, but failing should not interrupt the operation of fishd. My guess is that you are running Fedora, which has been shipping prerelease patches.

You shouldn't need to start fishd manually - do universal variables work without it?

@zanchey
Copy link
Member

@zanchey zanchey commented Sep 22, 2014

I've tested the Fedora-shipped version of fish, and yes - this does happen if you run fishd manually. I think we're running into #1084 as fishd tests if the socket is open, connects to it, then quits, and sometimes gets SIGPIPE.

I'd like to take de8bae3 for 2.1.1 as well - do you think that's reasonable?

Making releases is hard.

@zanchey
Copy link
Member

@zanchey zanchey commented Sep 22, 2014

Note that the behaviour exists in 2.1.0, so it may not be worth it.

@zanchey
Copy link
Member

@zanchey zanchey commented Sep 24, 2014

@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Sep 24, 2014

That has some user-visible symptoms so it seems like a nice fix to take. I'm OK if you want to add it.

@zanchey zanchey added this to the 2.1.1 milestone Sep 24, 2014
@zanchey zanchey self-assigned this Sep 24, 2014
@zanchey zanchey added the duplicate label Sep 24, 2014
@zanchey
Copy link
Member

@zanchey zanchey commented Sep 25, 2014

Cherry-picked as 0986b6d and retagged.

@zanchey zanchey closed this Sep 25, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.