Completing a folder misses an escape on the first char

[Profpatsch]

When completing a folder and selecting an entry from the list, if that entry starts with a character that should be escaped, it isn’t.

Example:

~/Downloads/[TAB TAB TAB
select entry [foobar] my file

Completion: ~/Downloads/[foobar\]\ my\ file

Note the missing \ before the first [.

[faho]

I can't reproduce with that specific case:

$ touch ~/Downloads/"[foobar] my file"
$ rm ~/Downloads/ # and tab-select the right file
$ rm ~/Downloads/\[foobar\]\ my\ file

I can however get this if I enter a literal "[" and then complete. Fish will complete the file, but won't escape the "[" (and then highlight it as invalid).

[Profpatsch]

@faho Then that was that.

[Profpatsch]

Oh, and aditionally: When starting the completion item with \ it doesn’t find anything. So there is no way to complete in a working way.

[adriaanzon]

I noticed today when yarn created a directory named ~, the completion doesn't escape the tilde character.

So imagine you're typing rm -rf <TAB><TAB>, it will produce rm -rf ~/ which is not quite what you had in mind.

[bmwalters]

I ran into this issue today (Fish 2.7.1), and was ready to file a new issue report when I found this one. Here's an asciicast:

This can cause a surprising behavior when interacting with a file named ~<your username> and selecting it using tab completion. Since the ~ is not escaped, the resulting command will reference ~<your username> which Fish helpfully expands to your home directory.

Notice that the tilde is actually escaped in the list of completion suggestions before selecting one, oddly enough.

[Profpatsch]

the resulting command will reference ~ which Fish helpfully expands to your home directory.

Hooooo, boy. That’s bad.

[ridiculousfish]

This should be fixed in 01d8745. Thanks for filing!