cd completion acts funny when spaces are present in the path #2300

Closed
tgkokk opened this Issue Aug 13, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@tgkokk

tgkokk commented Aug 13, 2015

$ mkdir a\ b\ c
$ cd a\ [TAB]

Now, i would expect to autocomplete a\ b\ c/, but instead it offers completions for every directory in the CWD. I guess that it treats the space as an argument separator.

Other commands (e.g. mkdir) work fine.

@faho

This comment has been minimized.

Show comment
Hide comment
@faho

faho Aug 13, 2015

Member

Same thing as #2299 - does #2289 change anything?

Member

faho commented Aug 13, 2015

Same thing as #2299 - does #2289 change anything?

@tgkokk

This comment has been minimized.

Show comment
Hide comment
@tgkokk

tgkokk Aug 13, 2015

Yeah, it autocompletes a\ a\ b\ c/. Still not perfect but better.

tgkokk commented Aug 13, 2015

Yeah, it autocompletes a\ a\ b\ c/. Still not perfect but better.

@faho

This comment has been minimized.

Show comment
Hide comment
@faho

faho Aug 14, 2015

Member

Other commands (e.g. mkdir) work fine.

There is no mkdir completion - it falls back to the generic file completion.

There's probably an issue with the completion comparison logic - it seems some of it happens before escaping.

Member

faho commented Aug 14, 2015

Other commands (e.g. mkdir) work fine.

There is no mkdir completion - it falls back to the generic file completion.

There's probably an issue with the completion comparison logic - it seems some of it happens before escaping.

faho added a commit that referenced this issue Oct 7, 2015

Rewrite __fish_complete_cd
This no longer uses "eval" (which is scary), and is a bit shorter (which
is nice).

Fixes #2299
Fixes #952

Improves #2300
Improves #562

@faho faho added the bug label Feb 21, 2016

@faho faho added this to the fish-future milestone Feb 21, 2016

@faho

This comment has been minimized.

Show comment
Hide comment
@faho

faho Mar 7, 2016

Member

I actually can't reproduce this anymore. Closing.

Member

faho commented Mar 7, 2016

I actually can't reproduce this anymore. Closing.

@faho faho closed this Mar 7, 2016

@faho faho modified the milestones: 2.3.0, fish-future Mar 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment