Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cd completion acts funny when spaces are present in the path #2300

Closed
tgkokk opened this issue Aug 13, 2015 · 4 comments
Closed

cd completion acts funny when spaces are present in the path #2300

tgkokk opened this issue Aug 13, 2015 · 4 comments
Labels
bug
Milestone

Comments

@tgkokk
Copy link

@tgkokk tgkokk commented Aug 13, 2015

$ mkdir a\ b\ c
$ cd a\ [TAB]

Now, i would expect to autocomplete a\ b\ c/, but instead it offers completions for every directory in the CWD. I guess that it treats the space as an argument separator.

Other commands (e.g. mkdir) work fine.

@faho
Copy link
Member

@faho faho commented Aug 13, 2015

Same thing as #2299 - does #2289 change anything?

@tgkokk
Copy link
Author

@tgkokk tgkokk commented Aug 13, 2015

Yeah, it autocompletes a\ a\ b\ c/. Still not perfect but better.

@faho
Copy link
Member

@faho faho commented Aug 14, 2015

Other commands (e.g. mkdir) work fine.

There is no mkdir completion - it falls back to the generic file completion.

There's probably an issue with the completion comparison logic - it seems some of it happens before escaping.

faho added a commit that referenced this issue Oct 7, 2015
This no longer uses "eval" (which is scary), and is a bit shorter (which
is nice).

Fixes #2299
Fixes #952

Improves #2300
Improves #562
@faho faho added the bug label Feb 21, 2016
@faho faho added this to the fish-future milestone Feb 21, 2016
@faho
Copy link
Member

@faho faho commented Mar 7, 2016

I actually can't reproduce this anymore. Closing.

@faho faho closed this Mar 7, 2016
@faho faho modified the milestones: 2.3.0, fish-future Mar 7, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.