Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

history --merge does not merge history in chronological order #2312

Closed
brettanomyces opened this issue Aug 18, 2015 · 1 comment
Closed

history --merge does not merge history in chronological order #2312

brettanomyces opened this issue Aug 18, 2015 · 1 comment
Assignees
Labels
bug
Milestone

Comments

@brettanomyces
Copy link

@brettanomyces brettanomyces commented Aug 18, 2015

Expected result: After history --merge commands in history should be shown in chronological order by the history command

Actual result: merged commands are shown after commands from the current session.

To reproduce:
Add save.fish to ~/.config/fish/functions

function save
    echo "- cmd:" $argv >> ~/.config/fish/fish_history
    echo "  when:" (date "+%s") >> ~/.config/fish/fish_history
    history --merge
end

Open a new shell and type the following

ls
save test
history

test appears below ls in the history, e.g.

save test
ls
test
...

fish, version 2.2.0-118-gaee71b5

@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Jun 24, 2016

Finally fixed this. Thanks for reporting it!

@zanchey zanchey added this to the next-2.x milestone Jul 3, 2016
floam added a commit to floam/fish-shell that referenced this issue Jul 4, 2016
@krader1961 krader1961 modified the milestones: fish 2.4.0, next-2.x Sep 3, 2016
@krader1961 krader1961 added the bug label Sep 3, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.