Multi-line prompts are repeated when the terminal window is resized. (repeat of #321)

[joesanford]

This bug is still occurring with both multi-line and single-line prompts.

[faho]

Could you add some more information? Which OS, which terminal, which fish version? What's your prompt? Any custom functions, especially signal handlers for SIGWINCH?

I cannot reproduce this on archlinux with konsole, fish 2.2.0-188-g3f43050, the classic+git prompt, a custom right-prompt and no custom SIGWINCH handlers.

[faho]

Also no issue with the example in #321 - `printf '1\n2\n$'.

[joesanford]

Mac OS X 10.10.5. Was able to replicate with both iTerm2 and Terminal. fish 2.2.0. Prompts that have shown this are Pythonista and bira. 4 of us at my work can all replicate this (same environment).

No custom functions, and it occurs when resizing window of the terminal.

[Determinant]

Same issue here. It does not seem related to the OS X version, I tried on both 10.10.5 and 10.11. It occurs when resizing window of the terminal.

[faho]

@Determinant, @joesanford: Can you try with current git master? It's possible this was already fixed since 2.2.0.

[Determinant]

Sorry, but I'm using 2.2.0. The problem still exists.

On Saturday, October 31, 2015, Fabian Homborg notifications@github.com
wrote:

@Determinant https://github.com/Determinant, @joesanford
https://github.com/joesanford: Can you try with current git master?
It's possible this was already fixed since 2.2.0.

—
Reply to this email directly or view it on GitHub
#2320 (comment)
.

--- This information is automatically generated ---
Welcome to My Blog : http://tedyin.com

ted.sybil aka. ymfoi aka. Ted Yin

[faho]

We know that you have this problem with 2.2.0, but what about newer versions (i.e. current git master, which isn't part of a release yet)?

[ridiculousfish]

I can reproduce on master.

The resizing stuff is rather tricky, but zsh seems to do much better here. I think what's going on is that we're soft-wrapping from the previous line, and need to have a hard return there.

[tylerhjones]

Is anyone else still receiving this problem?

[faho]

I still can't reproduce - newest fish, newest konsole on archlinux.

[ixjlyons]

I'm not sure about Github notifications when an issue is referenced from another, but I wanted to point out the duplicate issue I filed #2816 (sorry for the dup -- I searched but didn't see this one). I'm able to replicate this issue with all terminal emulators based on recent (gtk3) versions of vte.

I filed a bug report against vte here, and one of the developers seemed to figure out what the problem was. See comment 4 specifically.

I'd love to contribute to fish, and I have some C++ knowledge, but I'm still learning the basics of how shells work. I implemented the vte dev's suggestion here, but I have no idea whether or not this will cause side effects. Tests seem to pass, and I'm using it as my daily driver without issue so far.

[joesanford]

@faho The problem still exists on master on Mac OS X 10.10 with iTerm2. Multiple users where I work can confirm as well with the same setup

[faho]

@joesanford: Can you try erasing __fish_winch_handler? Unfortunately this means you'd need to run functions -e __fish_winch_handler interactively as it is defined only after the first prompt event (in __fish_config_interactive.fish), but it should do for a simple test.

The idea is that these terminals (iTerm2 and newer VTE) will reflow text themselves, so fish doing it just gets in the way. Or maybe their reflow doesn't work for our needs, let's see.