Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSYS, Mingw-w64: connect not recognized #2360

Closed
IngwiePhoenix opened this issue Sep 4, 2015 · 5 comments
Closed

MSYS, Mingw-w64: connect not recognized #2360

IngwiePhoenix opened this issue Sep 4, 2015 · 5 comments

Comments

@IngwiePhoenix
Copy link

@IngwiePhoenix IngwiePhoenix commented Sep 4, 2015

I followed the autotools instructions and generated the configure script. What happened is that it told me that a socket library was missing and connect was required. So I went and installed that:

pacman -Ss mingw-w64-x86_64-connect

That installed a libconnect.a inside the mingw folder. However, the configure script does not seem to pick it up and work with it.

Is there something I can do to get around this?

@zanchey
Copy link
Member

@zanchey zanchey commented Sep 4, 2015

That's not the right library - https://github.com/Alexpux/MINGW-packages/blob/master/mingw-w64-connect/PKGBUILD suggests that's a SOCKS client.

You might want to have a look at the MSYS2 package (https://github.com/Alexpux/MSYS2-packages/blob/master/fish/PKGBUILD) and build using those flags.

@adamkruszewski
Copy link

@adamkruszewski adamkruszewski commented Apr 7, 2016

Seems it will be of no use. Fish uses socket.h which isn't available under mingw. Someone would need to port it to use winsock.h when #define win32 is present.

@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Apr 7, 2016

We ought to be able to compile all of that out in Windows ("that" being check_running_fishd). it's just some compatibility junk. In fact we could probably even remove it for everyone in fish 2.3.0.

@krader1961
Copy link
Contributor

@krader1961 krader1961 commented Apr 8, 2016

We're so close to pushing 2.3.0 out the door I vote for removing that code after that's done. It's basically harmless, right? Other than causing build problems on MINGW, that is.

@krader1961 krader1961 added this to the next-2.x milestone Apr 8, 2016
@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Apr 8, 2016

Yeah, let's do it.

zanchey added a commit to zanchey/fish-shell that referenced this issue Jan 9, 2017
The socket(2) library function is only required on Linux, and does not
require special linker arguments to work.

Closes fish-shell#2360.
zanchey added a commit to zanchey/fish-shell that referenced this issue Jan 9, 2017
The socket(2) library function is only required on Linux, and does not
require special linker arguments to work.

Closes fish-shell#2360.
@zanchey zanchey mentioned this issue Jan 9, 2017
1 of 1 task complete
zanchey added a commit to zanchey/fish-shell that referenced this issue Jan 11, 2017
The socket(2) library function is only required on Linux, and does not
require special linker arguments to work.

Closes fish-shell#2360.
@zanchey zanchey closed this in 4bc220f Jan 11, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.