-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSYS, Mingw-w64: connect not recognized #2360
Comments
That's not the right library - https://github.com/Alexpux/MINGW-packages/blob/master/mingw-w64-connect/PKGBUILD suggests that's a SOCKS client. You might want to have a look at the MSYS2 package (https://github.com/Alexpux/MSYS2-packages/blob/master/fish/PKGBUILD) and build using those flags. |
Seems it will be of no use. Fish uses socket.h which isn't available under mingw. Someone would need to port it to use winsock.h when #define win32 is present. |
We ought to be able to compile all of that out in Windows ("that" being check_running_fishd). it's just some compatibility junk. In fact we could probably even remove it for everyone in fish 2.3.0. |
We're so close to pushing 2.3.0 out the door I vote for removing that code after that's done. It's basically harmless, right? Other than causing build problems on MINGW, that is. |
Yeah, let's do it. |
The socket(2) library function is only required on Linux, and does not require special linker arguments to work. Closes fish-shell#2360.
The socket(2) library function is only required on Linux, and does not require special linker arguments to work. Closes fish-shell#2360.
The socket(2) library function is only required on Linux, and does not require special linker arguments to work. Closes fish-shell#2360.
I followed the autotools instructions and generated the
configure
script. What happened is that it told me thata socket library
was missing andconnect
was required. So I went and installed that:That installed a
libconnect.a
inside the mingw folder. However, the configure script does not seem to pick it up and work with it.Is there something I can do to get around this?
The text was updated successfully, but these errors were encountered: