problem with scroll after <TAB><TAB> if the filename is too long

[simonbcn]

Ubuntu 14.04 64bits
fish v2.2.0 (installed from ppa:fish-shell/release-2)
terminator 0.97

I hit TAB twice to cycle through the possibilities but it does a wrong scroll and it deletes my command:

[pickfire]

Try using the latest fish, the fish version that you are using have bad completion:

• The highlight line stays when you had switched to a new one.

[simonbcn]

I've compiled and installed the git version and same problem.

[pickfire]

I cannot reproduce that.

[simonbcn]

I've tested with XTerm, LXTerminal and gnome-terminal. In all of them it fails.

[pickfire]

I use st, but I don't find any problem.

[simonbcn]

Tested with st and same problem.

[pickfire]

I can't reproduce it, I am using arch on arm architecture.

[simonbcn]

PC Intel 64 bits.

[zanchey]

That is strange. What is your locale set to? The output of locale may be useful.

[simonbcn]

Same problem with Arch Linux 64 bits.

$ locale
LANG=es_ES.utf8
LC_CTYPE="es_ES.utf8"
LC_NUMERIC="es_ES.utf8"
LC_TIME="es_ES.utf8"
LC_COLLATE="es_ES.utf8"
LC_MONETARY="es_ES.utf8"
LC_MESSAGES="es_ES.utf8"
LC_PAPER="es_ES.utf8"
LC_NAME="es_ES.utf8"
LC_ADDRESS="es_ES.utf8"
LC_TELEPHONE="es_ES.utf8"
LC_MEASUREMENT="es_ES.utf8"
LC_IDENTIFICATION="es_ES.utf8"
LC_ALL=

[faho]

@simonbcn: Which completion are you having this issue with? All of them? Just a file completion? Because in the original report there's makemkvcon, which I don't know and can't find and don't know if we have a completion for, and some unusual file/directory names (lots of spaces and parens).

It's also possible that it's a purely visual issue with file completion where a single file runs longer than a line.

[faho]

I get something like this, and as far as I can tell it is related to completion options using more than one line. @simonbcn: Does this improve if you make your terminal wider?

[simonbcn]

It fails in ttyX consoles too.
It doesn't fail always, only with certain folders and it isn't related with completion of any program.
For example:

In this example it doesn't fail:

[faho]

@simonbcn: Look carefully - in your failed example, it goes over the line, because one directories' name is too long. That doesn't happen in the passing one. And I'll bet that's what triggers it.

[simonbcn]

ok, that is the bug. I change the title of this issue.

[floam]

Does this still happen?

[jusga]

Steps to reproduce this independent of terminal size with fish, version 2.5.0-259-gc0de8afa:

• Start with an empty directory and create some files:

  > touch file(seq -w 1 $LINES)
  

• Then we need a file with a long name:

  > touch (string repeat -n $COLUMNS a)
  

• Type any command with filename completion and hit <Tab> repeatedly.

[faho]

I can no longer reproduce this, closing.

[zanchey]

It's broken in 3.1.2 but working in master, so I'll mark this as fixed in 3.2.0.

[krobelus]

Sounds like ada03d3 (Correct pager size when command line soft-wraps)