-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The strange ‐
in the example of help test
, which should be -
#2673
Comments
I found it has been fixed in latest codebase. (My version is But I also found another two places using it:
Not sure if they are issues, just list them here as reminders. |
These two have been fixed, thanks!
I really suggest upgrading - 2.2.0 is quite nice! |
@faho The output of
When will we have a new fish release? |
That output also works for me.
I don't know yet. Is there anything keeping you from going to 2.2.0? |
@faho Sorry, I forgot to mention the output of previous reply is from 2.2.0, and I feel a little surprise the And in my shell, it reports errors:
|
That's weird. It's of course possible that it's something wrong with the toolchain used to build the docs (some formatter programs like using fancy punctuation) - what OS is this on and did you build fish yourself or is it from someone's packages? All I know is that I can copy from my |
My system is OS X EI Capitan 10.11.1, and using iTerm2 2.1.4. I install fish via
Do you need any information else? |
@freewind: Okay, someone on gitter confirmed your findings. Now we need to find out where it comes from. It's not in the source, so it should come in during conversion, and we use doxygen for that - which version of that do you have (I have 1.8.11)? Unfortunately, I can't find anything on "-" being converted to anything in the doxygen documentation - I've only found something about "--" and "---". If you want, you can try changing the "-" in doc_src/test.txt to "-". |
The problem (locale-dependent) is caused by nroff used in |
@jakwings: Which locale triggers that? I've got de_DE.UTF-8 and also tried en_US.UTF-8 and C, none of which fail. |
I see the bad dashes in |
en_US.UTF-8 on mac, using /usr/bin/nroff I just checked
|
Problem solved somehow: Have fun with macros? |
There's others, this is very annoying. |
I can still reproduce this. The output of |
This was fixed by the groff 1.20 release with the following comment in ChangeLog.120. This is basically the same fix documented in the mailing list message I linked to in my previous comment:
This is seen on macOS up through the latest release, Sierra, because it still ships with groff 1.19. Whereas Ubuntu 16.04 (and probably most Linux distros released in the past two years) has groff 1.22 (released 2014-11-04). It looks like simply shipping our own tmac file to augment the man.tmac file is all that's needed. |
When you print
help test
in fishshell, it will print usage and an example:Can you find anything strange? Perhaps not.
But if you just copy and paste it to fish, and run it, it will show two errors:
The
‐
is not the same as the normal hyphen-
!!! (You can copy it and search in page)It can be a big problem for newbies of fish like me, I copied it to my shell and spent several hours to figure out why my
if test
doesn't working.(I'm afraid there are similar issues in other examples, could you do a global search on the codebase when you fix it?)
The text was updated successfully, but these errors were encountered: