Better error for windows line endings in the shebang

[brenogil]

I have recently switched to fish and I have been trying to run some .sh scripts.
Usually I have no problem but for one particular script I get the error below.

Observed behavior:

Failed to execute process './alt_script.sh'. Reason:
', which is not an executable command.he interpreter '/bin/sh

I believe at least the message could be improved, if nothing else.

Other comments:

I have tried playing with different shebangs:

!/bin/sh

!/bin/bash

!/usr/local/bin/fish

---

Fish version: fish, version 2.2.0

Operating system: OSX 10.10.5 - Homebrew

[faho]

Could you upload the script?

', which is not an executable command.he interpreter '/bin/sh

I do believe you've made a copy-paste mistake here - for me the error is

The file 'FILENAME' specified the interpreter 'INTERPRETER', which is not an executable command.

Also, check that the mentioned interpreter actually exists and is executable (test -x $INTERPRETER).

And what is your locale (echo $LANG, dunno if OSX has a locale command)?

[brenogil]

I do believe you've made a copy-paste mistake here

Also, check that the mentioned interpreter actually exists and is executable (test -x $INTERPRETER).

Returns nothing. Could this be the problem?

And what is your locale (echo $LANG, dunno if OSX has a locale command)?

locale
LANG="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_CTYPE="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_ALL="en_US.UTF-8"

[faho]

Returns nothing. Could this be the problem?

It should set $status to 1 if it doesn't - your prompt displays a red cross then if I'm not mistaken.

LC_ALL="en_US.UTF-8"

You usually do not want to set LC_ALL, as it overrides all other locale variables.

Otherwise, I got nothing. No clue - anyone else? @fish-shell/contributors?

[brenogil]

You usually do not want to set LC_ALL, as it overrides all other locale variables.

Ok. I undid it.

It should set $status to 1 if it doesn't - your prompt displays a red cross then if I'm not mistaken.

... I'm not sure I fully understand this. Are there any resources about it around?

[faho]

http://fishshell.com/docs/current/index.html#variables (a bit down, under "The status variable"):

Whenever a process exits, an exit status is returned to the program that started it (usually the shell). This exit status is an integer number, which tells the calling application how the execution of the command went. In general, a zero exit status means that the command executed without problem, but a non-zero exit status means there was some form of problem. Fish stores the exit status of the last process in the last job to exit in the status variable.

and

http://fishshell.com/docs/current/tutorial.html#tut_exit_status.

Basically, test returns a status. When the test fails (i.e. the file isn't executable - which it also can't be if it doesn't exist) it will return 1. Your prompt acts on it if the last command returned something > 0 and displays a red cross, like you can see in your screenshot, so you can just execute a test and see if it failed.

[brenogil]

Thanks!
test -x alt_script.sh
test alt_script.sh
test -x $INTERPRETER

all return $status 0

[faho]

test alt_script.sh

That's not how test works. It has a few operators, but if you're not handing it any, it will check if the arguments are not empty (in a pure text sense), so it goes "Oh, I've received the text 'alt_script.sh' - that's text, so let's return 0!". See http://fishshell.com/docs/current/commands.html#test for more information.

test -x $INTERPRETER

By "$INTERPRETER", I meant the full path to the interpreter you're using in the shebang, e.g. test -x /bin/bash (that test returns 0 in this case is #2037, an instance of POSIX, the standard we follow for it, being stupid).

[brenogil]

stupid me!

test -x /bin/bash
test -x /bin/sh

all return 0.

As I said, I have been able to run similar scripts.
I find the error message strange more than anything

[faho]

As I said, I have been able to run similar scripts.

Which is why the question is: What's different about this one? Can you upload it?

[faho]

Did this script ever have contact with a windows system? Does it work if you copy it by hand (i.e. not copy-and-pasting, but entering the text anew in a new file)?

[faho]

I can reproduce the weird error message with the following script:

printf '%s\r' \#!/bin/bash 'echo banana' > why.sh
chmod +x why.sh
./why.sh

You might notice that printf here has a "\r" instead of the more usual "\n". That's what windows usually uses for line endings, and it's been a pain for the last two decades.

To fix your script, run sed 's/\r/\n' -i /path/to/script or dos2unix or something like that.

It's possible we could detect that and print a better error message.

[faho]

Or, since you use emacs, open it with that and do M-x set-buffer-file-coding-system utf-8-unix, then save.

[brenogil]

Did this script ever have contact with a windows system?

Yes! It is a script I tried to convert from a .bat

Or, since you use emacs, open it with that and do M-x set-buffer-file-coding-system utf-8-unix, then save.

This worked in the sense that error message does not appear anymore. :)
./alt_script.sh: line 20: wine: command not found
./alt_script.sh: line 24: wine: command not found
./alt_script.sh: line 29: wine: command not found
./alt_script.sh: line 34: wine: command not found

Does it work if you copy it by hand (i.e. not copy-and-pasting, but entering the text anew in a new file)?

Yes

[faho]

./alt_script.sh: line 20: wine: command not found

Let me go out on a limb here - my guess is, and this is purely a guess, that you either don't have wine installed or don't have it installed in $PATH (command -s wine doesn't work).

[brenogil]

I don't think its is the case. I've been relying heavily on wine. (that sounds bad)
./alt_script.sh: line 52: mkdir: command not found
./alt_script.sh: line 64: rm: command not found
./alt_script.sh: line 66: `done'

I guess I'll have to figure it out what is going on...