Wrong highlight for wildcards in input redirection #2789

Closed
f1u77y opened this Issue Mar 2, 2016 · 2 comments

Projects

None yet

3 participants

@f1u77y
Contributor
f1u77y commented Mar 2, 2016

Reproduction steps:

  1. Type a command with a wildcard in input redirection in a such way that's exactly one match for that wildcard(let it be cat < /dev/ur*ndom)

Expected behaviour

fish should highlight /dev/ur*ndom with $fish_color_redirection or don't execute command correctly

Observed behaviour

fish highlights /dev/ur*ndom with $fish_color_error but executes command correctly

Additional information

$ fish --version
fish, version 2.2.0
@ridiculousfish ridiculousfish self-assigned this Mar 2, 2016
@ridiculousfish
Member

Nice find

@krader1961 krader1961 added the bug label Mar 24, 2016
@krader1961 krader1961 added this to the fish-future milestone Mar 24, 2016
@ridiculousfish
Member

We were neglecting to set the generation count for the background highlighting thread, so we were always cancelling the highlight (thinking we were interrupted).

@ridiculousfish ridiculousfish modified the milestone: next-2.x, fish-future Jul 9, 2016
@krader1961 krader1961 modified the milestone: fish 2.4.0, next-2.x Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment