New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong highlight for wildcards in input redirection #2789

Closed
f1u77y opened this Issue Mar 2, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@f1u77y
Contributor

f1u77y commented Mar 2, 2016

Reproduction steps:

  1. Type a command with a wildcard in input redirection in a such way that's exactly one match for that wildcard(let it be cat < /dev/ur*ndom)

Expected behaviour

fish should highlight /dev/ur*ndom with $fish_color_redirection or don't execute command correctly

Observed behaviour

fish highlights /dev/ur*ndom with $fish_color_error but executes command correctly

Additional information

$ fish --version
fish, version 2.2.0

@ridiculousfish ridiculousfish self-assigned this Mar 2, 2016

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Mar 2, 2016

Member

Nice find

Member

ridiculousfish commented Mar 2, 2016

Nice find

@krader1961 krader1961 added the bug label Mar 24, 2016

@krader1961 krader1961 added this to the fish-future milestone Mar 24, 2016

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Jul 9, 2016

Member

We were neglecting to set the generation count for the background highlighting thread, so we were always cancelling the highlight (thinking we were interrupted).

Member

ridiculousfish commented Jul 9, 2016

We were neglecting to set the generation count for the background highlighting thread, so we were always cancelling the highlight (thinking we were interrupted).

@ridiculousfish ridiculousfish modified the milestones: next-2.x, fish-future Jul 9, 2016

@krader1961 krader1961 modified the milestones: fish 2.4.0, next-2.x Sep 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment