Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 24-bit support for neovim later #2792

Closed
faho opened this issue Mar 3, 2016 · 3 comments
Closed

Enable 24-bit support for neovim later #2792

faho opened this issue Mar 3, 2016 · 3 comments

Comments

@faho
Copy link
Member

@faho faho commented Mar 3, 2016

We currently explicitly disable 24-bit support for neovim because that had a release with a fubar'd implementation (all text would show up white).

We should enable it once that release either isn't supported or isn't in circulation anymore.

See #2768.

@mqudsi
Copy link
Contributor

@mqudsi mqudsi commented Sep 10, 2017

Fixed for 3.0

@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Sep 10, 2017

The commit bb419d4 appears to have broken the tests on my macOS and Linux boxes. Reverted as c2a5e7ae27115f1e751deb0d6ef7c92a82b4e18c. @mqudsi

@zanchey zanchey reopened this Sep 10, 2017
@mqudsi mqudsi closed this in 13fd9be Sep 10, 2017
@mqudsi
Copy link
Contributor

@mqudsi mqudsi commented Sep 10, 2017

I think it was the unprefixed and in if and not set. Fixed again in 13fd9be.

@faho faho modified the milestones: fish-future, fish-3.0 Jan 11, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants