Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git completion on a branch when doing a force push #2879

Closed
rocketraman opened this issue Mar 31, 2016 · 1 comment
Closed

Git completion on a branch when doing a force push #2879

rocketraman opened this issue Mar 31, 2016 · 1 comment

Comments

@rocketraman
Copy link
Contributor

When doing git completion, fish generally completes the branch name e.g.

git push origin <completion here>

However, when doing a force push with a +, the branch completion does not work:

git push origin +<no completion here>

Fish version: 2.2.0

Operating system: Fedora Linux

Terminal or terminal emulator: Konsole

@faho
Copy link
Member

faho commented Mar 31, 2016

Yes, this needs to be implemented.

When it is, this should not recommend all branches with a "+", but only complete branches even after a "+" and maybe give a standalone "+" with a description of "force push" or something. Everything else would cause way too many options, about half of them dangerous.

@faho faho added this to the fish-future milestone Mar 31, 2016
@faho faho closed this as completed in fde26d4 Apr 30, 2016
faho added a commit that referenced this issue Apr 30, 2016
This signifies a force-push.

To avoid cluttering, only complete branches if a + is already given.

Fixes #2879.

(cherry picked from commit fde26d4)
@faho faho modified the milestones: 2.3.0, fish-future Apr 30, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants