New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop putting newline character (and ellipsis) to break long lines #300

Closed
maxfl opened this Issue Aug 29, 2012 · 7 comments

Comments

Projects
None yet
5 participants
@maxfl
Contributor

maxfl commented Aug 29, 2012

...in both output and commandline editor.

In fact terminal emulators handle long lines by themselves though sometimes in a different way.
I use rxvt-unicode and here are the differences I see between fish and bash.
I use 'll' command in a folder with symlinks to produce wide output.

  1. When using fish, resizing terminal doesn't reformat lines. Split lines remain split.
    If you make terminal wider, you see a line-break. If you make the terminal window narrower, text that goes outside gets lost.

When I use bash, resizing terminal reformats the output. Which is nice.

  1. There already was a discussion in the mailing list about the ellipsis which prevent long command-line from being copy-pasted.

  2. Long command lines are also can not be copy-pasted because of newline character which is interpreted as 'Return' when pasting. If I copy a split long command line from bash, it is pasted as single line. When I do it in fish, fish tries to execute every part preceding the 'newline'.

As for me I prefer the bash behavior in this case in all the cases. I propose to switch to it where it is possible.

@jonclayden

This comment has been minimized.

Show comment
Hide comment
@jonclayden

jonclayden Aug 29, 2012

Agreed. (I was the OP on the mailing list thread relating to this.) I appreciate that the ellipsis gives a visual cue of the split, but I think its better to let the terminal emulator handle this so as to make copy/paste work cleanly. The point about window resizing is also a good one.

jonclayden commented Aug 29, 2012

Agreed. (I was the OP on the mailing list thread relating to this.) I appreciate that the ellipsis gives a visual cue of the split, but I think its better to let the terminal emulator handle this so as to make copy/paste work cleanly. The point about window resizing is also a good one.

@phred

This comment has been minimized.

Show comment
Hide comment
@phred

phred Sep 13, 2012

+1, it can be really obnoxious.

phred commented Sep 13, 2012

+1, it can be really obnoxious.

@siteshwar

This comment has been minimized.

Show comment
Hide comment
@siteshwar

siteshwar Sep 17, 2012

Member

Fixed with this commit :

To git@github.com:fish-shell/fish-shell.git
86a978d..16f2ffc master -> master

Member

siteshwar commented Sep 17, 2012

Fixed with this commit :

To git@github.com:fish-shell/fish-shell.git
86a978d..16f2ffc master -> master

@siteshwar

This comment has been minimized.

Show comment
Hide comment
@siteshwar

siteshwar Sep 17, 2012

Member

It seems fish is still adding newlines when I try to copy text from multiple lines. I will try to fix it.

Member

siteshwar commented Sep 17, 2012

It seems fish is still adding newlines when I try to copy text from multiple lines. I will try to fix it.

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Oct 1, 2012

Member

This is way more complicated than one would think...

Soft wrapping should work with commit a661c03.

Member

ridiculousfish commented Oct 1, 2012

This is way more complicated than one would think...

Soft wrapping should work with commit a661c03.

@maxfl

This comment has been minimized.

Show comment
Hide comment
@maxfl

maxfl Oct 1, 2012

Contributor

that is so cool. Thank you very much.
Please, decide when it is time to close the ticket. I will leave it as is.

Contributor

maxfl commented Oct 1, 2012

that is so cool. Thank you very much.
Please, decide when it is time to close the ticket. I will leave it as is.

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Oct 3, 2012

Member

There's still a lot of issues around window resizing, in particular fast window resizing (though many of those issues were present in the original fish). I speculate that the issue is that the SIGWINCH signal gets delivered during a repaint, causing inconsistent rendering and general weirdness.

Commit 6b026e3 improves the situation a bit, and I think we're at parity with fish 1.x for resizing.

Member

ridiculousfish commented Oct 3, 2012

There's still a lot of issues around window resizing, in particular fast window resizing (though many of those issues were present in the original fish). I speculate that the issue is that the SIGWINCH signal gets delivered during a repaint, causing inconsistent rendering and general weirdness.

Commit 6b026e3 improves the situation a bit, and I think we're at parity with fish 1.x for resizing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment