Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No completion offered for remote branch in git push #3035

Closed
ashwin opened this issue May 17, 2016 · 3 comments
Closed

No completion offered for remote branch in git push #3035

ashwin opened this issue May 17, 2016 · 3 comments
Assignees
Milestone

Comments

@ashwin
Copy link

@ashwin ashwin commented May 17, 2016

The command to push a local branch to a remote branch is:

git push remote_name local_branch:remote_branch

Fish does tab completion when typing local_branch, but does not complete when typing the remote_branch in the above command. The remote_branch completion works fine in other commands like git merge remote_name/remote_branch


Fish version: 2.2.0
Operating system: Ubuntu 14.04

@faho faho self-assigned this May 19, 2016
@faho faho closed this in 9cee3f1 May 19, 2016
@zanchey zanchey added this to the next-2.x milestone May 20, 2016
@faho faho modified the milestones: fish 2.4.0, next-2.x Sep 4, 2016
@obfuscated
Copy link

@obfuscated obfuscated commented Oct 19, 2019

There is another case which doesn't work:

git push remote_name 1245ac417df667b314f0344ac24d54ce4374b1f7:remote_branch

Here fish doesn't provide any completion for the remote_branch. If I type a space after : the completions work.
Running 3.0.2 here.
Is this the same issue or should I open new one?

krobelus added a commit that referenced this issue Oct 19, 2019
When there is already a "src:", we assume that it is a valid ref and
just complete "dst". This allows completion of dest if src is e.g. a
commit SHA (completing all possible refs would probably impact
performance).

See issue #3035.
@krobelus
Copy link
Member

@krobelus krobelus commented Oct 19, 2019

@obfuscated makes sense, I just fixed that, will be in 3.1.0

@obfuscated
Copy link

@obfuscated obfuscated commented Oct 19, 2019

@krobelus Cool, thanks for the fast response. :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.