Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish_mode_prompt not working in 2.3.0 #3067

Closed
1 task done
faho opened this issue May 25, 2016 · 2 comments
Closed
1 task done

fish_mode_prompt not working in 2.3.0 #3067

faho opened this issue May 25, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@faho
Copy link
Member

@faho faho commented May 25, 2016

From #3047 (comment):

Aaaaaaaaaaah! It seems in our rebasing we missed parts of 8ab980b.

fish_mode_prompt in 2.3.0 still checks $__fish_vi_mode, but the functions don't set it anymore. The easiest workaround is probably set -g __fish_vi_mode 1.

In case we do a stable release based on the Integration_2.3.0 branch that one should definitely be included. If it's instead based on master this is already fixed.

Sorry!


For 2.3.1 release:

  • Update release notes
@faho faho added this to the next-2.x milestone May 25, 2016
@faho faho self-assigned this May 25, 2016
@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented May 25, 2016

Yikes. Let's do a 2.3.1 release with this and anything else that we find.

@ridiculousfish ridiculousfish added this to the 2.3.1 milestone May 25, 2016
@ridiculousfish ridiculousfish removed this from the next-2.x milestone May 25, 2016
zanchey added a commit that referenced this issue Jun 6, 2016
This makes fish_mode_prompt rely on $fish_key_bindings instead.

fish_bind_mode is also set in default mode (only always "default"), so
it can't be used as the indicator.

Closes #3067.

(cherry picked from commit 8ab980b)
@zanchey
Copy link
Member

@zanchey zanchey commented Jun 6, 2016

Cherry-picked as fcbeddc.

@zanchey zanchey closed this Jun 6, 2016
janernsting added a commit to janernsting/dotfiles that referenced this issue Jul 5, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants