fish_mode_prompt not working in 2.3.0 #3067

Closed
faho opened this Issue May 25, 2016 · 2 comments

Projects

None yet

3 participants

@faho
Member
faho commented May 25, 2016 edited

From #3047 (comment):

Aaaaaaaaaaah! It seems in our rebasing we missed parts of 8ab980b.

fish_mode_prompt in 2.3.0 still checks $__fish_vi_mode, but the functions don't set it anymore. The easiest workaround is probably set -g __fish_vi_mode 1.

In case we do a stable release based on the Integration_2.3.0 branch that one should definitely be included. If it's instead based on master this is already fixed.

Sorry!


For 2.3.1 release:

  • Update release notes
@faho faho added the bug label May 25, 2016
@faho faho added this to the next-2.x milestone May 25, 2016
@faho faho self-assigned this May 25, 2016
@ridiculousfish
Member
ridiculousfish commented May 25, 2016 edited

Yikes. Let's do a 2.3.1 release with this and anything else that we find.

@ridiculousfish ridiculousfish modified the milestone: 2.3.1, next-2.x May 25, 2016
@zanchey zanchey added a commit that referenced this issue Jun 6, 2016
@faho @zanchey faho + zanchey Remove $__fish_vi_mode
This makes fish_mode_prompt rely on $fish_key_bindings instead.

fish_bind_mode is also set in default mode (only always "default"), so
it can't be used as the indicator.

Closes #3067.

(cherry picked from commit 8ab980b)
fcbeddc
@zanchey
Member
zanchey commented Jun 6, 2016

Cherry-picked as fcbeddc.

@zanchey zanchey closed this Jun 6, 2016
@janernsting janernsting added a commit to janernsting/dotfiles that referenced this issue Jul 5, 2016
@janernsting janernsting Ignore fish-shell preset vi mode indicator 569b997
@olbrew olbrew referenced this issue in oh-my-fish/theme-agnoster Aug 7, 2016
Merged

Simplify and fix right prompt #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment