Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
`history --delete` (fish script, not builtin) is broken by entries with newlines #31
The following comment is from issue #3224 that I opened because I didn't find this issue when I did a superficial search.
The history --delete command is broken. If your history contains multiline commands each line is listed as an individual entry you can select for deletion. That's obviously bogus. It might be possible to fix that. However, I'm wondering if it wouldn't make more sense to simply change the UI to eliminate selecting individual entries for deletion. Just give the user the choice of deleting all or none of the matching entries.
Also, including the recently introduced -t or --with-time flag produces output that makes selecting an individual entry for deletion impossible. Yet another reason to remove that capability.
I noticed this while working on issue #3224.
This fixes several problems with how the builtin `history` command handles arguments. It now complains and refuses to do anything if the user specifies incompatible actions (e.g., `--search` and `--clear`). It also fixes a regression introduced by previous changes with regard to invocations that don't explicitly specify `--search` or a search term. Enhances the history man page to clarify the behavior of various options. This change is already far larger than I like so unit tests will be added in a separate commit. Fixes #3224. Note: This fixes only a couple problems with the interactive `history --delete` command in the `history` function. The main problem will be dealt with via issue #31.
Running into this same bug when a command is in a begin/end block spanning multiple lines. I would expect slightly different behaviour to what @ridiculousfish talks about in the original report.
for example, if my history contains
history --prefix echo should return no results (as it does currently)
(although it would possibly be even nicer if it indented output in the same way writing "begin[return]" at the interactive prompt does)
history --prefix begin --delete should allow me to delete the entire block (it currently does not)
history --contains echo --delete should also allow me to delete the entire block (it currently does not)
I don't think it would be consistent if "history --contains echo --delete" deleted only the lines in the block that contained echo, because then in the example above you'd be left with
in your history and it wouldn't make sense.
It seems like the only sensible solution is adding another flag to request that the
It is unlikely this will be implemented in time for the 2.4.0 release but I'm going to focus on fixing this any way. Fixing this will make a nice finale to the other history improvements that have been made in the past couple of months.
Yes. I was worried about potentially having an embedded NUL in the history but that's impossible today and we should prohibit it in the future if we ever switch from "char *" style strings to C++ string objects in all the history code paths.