/fish-shell

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`git commit --<tab>` shows error message when outside of a repository #3114

Closed
mineo opened this Issue Jun 4, 2016 · 1 comment

Comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
  fish 2.3.1
3 participants
@mineo @Fuyukai @faho
@mineo
Contributor

mineo commented Jun 4, 2016 •
edited by floam

Reproduction Steps:

  1. git commit --<tab>

Expected behavior:

Just show me the list of options.

Observed behavior:

wieland@mineo ~> git commit --fatal: Not a git repository (or any of the parent directories): .git

--amend  (Amend the log message of the last commit)  --help  (Display the manual of a git command)

Additional information:

Trying to complete filenames at that point doesn't make sense, git commit --filename doesn't work.

Fish version: 2.3.0

For 2.3.1 release:

  • Update release notes

@faho faho added the bug label Jun 4, 2016

@faho faho added this to the 2.3.1 milestone Jun 4, 2016

@faho faho closed this in 410d92e Jun 4, 2016

@Fuyukai

This comment has been minimized.

Show comment
Hide comment
@Fuyukai

Fuyukai Jun 4, 2016

That's some damn fast bug resolution right there.

Fuyukai commented Jun 4, 2016

That's some damn fast bug resolution right there.

@krader1961 krader1961 referenced this issue Jun 21, 2016

Closed

Roll a 2.3.1 release #3106

krader1961 added a commit that referenced this issue Jun 21, 2016

@faho @krader1961
git completions: Ignore stderr everywhere 
This allows us to run git commands outside of a git repo.

Fixes #3114.
29664c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment