Confusing completion behavior on similar nested folders. #3211

Closed
lunixbochs opened this Issue Jul 6, 2016 · 3 comments

Projects

None yet

4 participants

@lunixbochs
Contributor
lunixbochs commented Jul 6, 2016 edited

Talk about the the issue here.

fish verison installed: 2.3.1
OS/terminal used: OS X / Terminal.app

Reproduction steps

  1. mkdir -p at-dr2/asdf dr
  2. cd dr/a<tab>

Expected results

Fish should not remove manually typed valid directories when performing completion. This should result in an error and no completion should occur.

Actual results

~ $ cd at-dr2/asdf/
@llwu
llwu commented Jul 7, 2016 edited

I don't agree with the "no completion" verdict. Dropping a menu for a single fuzzy completion instead of automatically selecting it could be a good idea though (or allowing it to be configured).

@ridiculousfish
Member

I think it's reasonable to say, if there's an exact match of a path component, do not attempt fuzzy completion on that component even if we get no completions.

@ridiculousfish ridiculousfish self-assigned this Jul 7, 2016
@ridiculousfish ridiculousfish added this to the fish-future milestone Jul 7, 2016
@faho faho added the enhancement label Jul 8, 2016
@ridiculousfish ridiculousfish added a commit that closed this issue Oct 2, 2016
@ridiculousfish ridiculousfish Don't modify valid directory segments in fuzzy completions
When performing fuzzy completion, if a directory segment is
valid, then don't consider it for a fuzzy match even if
the literal match produces no results.

Fixes #3211
c0c2e1d
@ridiculousfish
Member

Fixed as c0c2e1d . Thanks for filing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment