Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing completion behavior on similar nested folders. #3211

Closed
2 tasks done
lunixbochs opened this issue Jul 6, 2016 · 3 comments
Closed
2 tasks done

Confusing completion behavior on similar nested folders. #3211

lunixbochs opened this issue Jul 6, 2016 · 3 comments
Assignees
Labels
enhancement release notes Something that is or should be mentioned in the release notes
Milestone

Comments

@lunixbochs
Copy link
Contributor

lunixbochs commented Jul 6, 2016

Talk about the the issue here.

fish verison installed: 2.3.1
OS/terminal used: OS X / Terminal.app

Reproduction steps

  1. mkdir -p at-dr2/asdf dr
  2. cd dr/a<tab>

Expected results

Fish should not remove manually typed valid directories when performing completion. This should result in an error and no completion should occur.

Actual results

~ $ cd at-dr2/asdf/
@llllvvuu
Copy link

llllvvuu commented Jul 7, 2016

I don't agree with the "no completion" verdict. Dropping a menu for a single fuzzy completion instead of automatically selecting it could be a good idea though (or allowing it to be configured).

@ridiculousfish
Copy link
Member

ridiculousfish commented Jul 7, 2016

I think it's reasonable to say, if there's an exact match of a path component, do not attempt fuzzy completion on that component even if we get no completions.

@ridiculousfish ridiculousfish self-assigned this Jul 7, 2016
@ridiculousfish ridiculousfish added this to the fish-future milestone Jul 7, 2016
@ridiculousfish ridiculousfish modified the milestones: fish 2.4.0, fish-future Oct 2, 2016
@ridiculousfish
Copy link
Member

ridiculousfish commented Oct 2, 2016

Fixed as c0c2e1d . Thanks for filing this!

@ridiculousfish ridiculousfish added the release notes Something that is or should be mentioned in the release notes label Oct 2, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement release notes Something that is or should be mentioned in the release notes
Projects
None yet
Development

No branches or pull requests

4 participants