Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish_vi_cursor is not used by default #3215

Closed
faho opened this issue Jul 9, 2016 · 0 comments
Closed

fish_vi_cursor is not used by default #3215

faho opened this issue Jul 9, 2016 · 0 comments

Comments

@faho
Copy link
Member

@faho faho commented Jul 9, 2016

When vi-mode is enabled, the mode prompt is too, but the cursor function isn't. We should expose the feature by default.

There's also the issue that it doesn't set default cursor shapes, so even if it were called by default it wouldn't do anything. It should probably default to "line" for insert mode and "block" for default/normal mode.

fish version installed: fish, version 2.3.1-363-g733e960

OS/terminal used: Archlinux, Konsole

Reproduction steps

  1. fish_vi_key_bindings
  2. Switch between default and insert mode (e.g enter escape then "i")

Expected results

Fish should change the cursor.

Actual results

It doesn't.

(Related to #1403 (comment))

@faho faho added this to the next-2.x milestone Jul 9, 2016
@faho faho closed this in cac3b23 Sep 4, 2016
@faho faho modified the milestones: fish 2.4.0, next-2.x Sep 4, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.