fish_vi_cursor is not used by default #3215

faho opened this Issue Jul 9, 2016 · 0 comments


None yet

1 participant

faho commented Jul 9, 2016

When vi-mode is enabled, the mode prompt is too, but the cursor function isn't. We should expose the feature by default.

There's also the issue that it doesn't set default cursor shapes, so even if it were called by default it wouldn't do anything. It should probably default to "line" for insert mode and "block" for default/normal mode.

fish version installed: fish, version 2.3.1-363-g733e960

OS/terminal used: Archlinux, Konsole

Reproduction steps

  1. fish_vi_key_bindings
  2. Switch between default and insert mode (e.g enter escape then "i")

Expected results

Fish should change the cursor.

Actual results

It doesn't.

(Related to #1403 (comment))

@faho faho added this to the next-2.x milestone Jul 9, 2016
@faho faho added a commit that closed this issue Sep 4, 2016
@faho faho Use fish_vi_cursor by default
Fixes #3215.
@faho faho closed this in cac3b23 Sep 4, 2016
@faho faho modified the milestone: fish 2.4.0, next-2.x Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment