Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abbr -e completion mis-escapes things #3267

Closed
2 tasks done
floam opened this issue Jul 26, 2016 · 1 comment
Closed
2 tasks done

abbr -e completion mis-escapes things #3267

floam opened this issue Jul 26, 2016 · 1 comment
Labels
bug Something that's not working as intended completions
Milestone

Comments

@floam
Copy link
Member

floam commented Jul 26, 2016

  • Have you checked if problem occurs with fish 2.3.1?
  • Tried fish without third-party customizations (check sh -c 'env HOME=$(mktemp -d) fish')?

The completion of abbr -e can expand such that it escapes single quotes when we don't want that.

fish version installed (fish --version): 2.3.1

OS/terminal used: OS X

Reproduction steps

  1. abbr \&\& '; and'
  2. abbr -e <TAB>
  3. Select the completion we just made

Expected results

It should expand to abbr -e '&&' or abbr -e \&\&

Actual results

Expands to this, which causes an error:

> abbr -e \'\&\&\' 
abbr: no such abbreviation ''&&''
@faho faho added bug Something that's not working as intended completions labels Jul 26, 2016
@faho faho closed this as completed in 49008d7 Jul 26, 2016
@faho
Copy link
Member

faho commented Jul 26, 2016

The issue here was that abbr --show already escapes things, so we complete an escaped thing and escape it again.

@zanchey zanchey added this to the next-2.x milestone Aug 17, 2016
@krader1961 krader1961 modified the milestones: fish 2.4.0, next-2.x Sep 3, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something that's not working as intended completions
Projects
None yet
Development

No branches or pull requests

4 participants