Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When you attempt to tab complete a brew command an error is thrown #3360

Closed
2 tasks done
Nocturnhabeo opened this issue Sep 7, 2016 · 3 comments
Closed
2 tasks done

Comments

@Nocturnhabeo
Copy link

Nocturnhabeo commented Sep 7, 2016

  • Have you checked if problem occurs with fish 2.3.1?
  • Tried fish without third-party customizations (check sh -c 'env HOME=$(mktemp -d) fish')?

fish version installed (fish --version): 2.3.1

OS/terminal used: OSX 10.11.6 El Capitan

When I try to tab complete brew install kali it fails with:
No matches for wildcard '$formuladir/.rb'.
/usr/local/Cellar/fish/2.3.1/share/fish/completions/brew.fish (line 3): ls $formuladir/
.rb | sed 's/.rb$//' | sed "s|^$formuladir||"
^
in function '__fish_brew_formulae'
called on standard input

in command substitution
called on standard input

Reproduction steps

  1. type brew install kali
  2. hit tab
@Nocturnhabeo
Copy link
Author

I can't get the error message the format correctly but the ^ is pointed to the $formuladir

@faho
Copy link
Member

faho commented Sep 7, 2016

This should already be fixed by #3309.

@faho faho closed this as completed Sep 7, 2016
@faho faho added this to the fish 2.4.0 milestone Sep 7, 2016
@floam
Copy link
Member

floam commented Sep 8, 2016

Homebrew should probably want to backport that change in master for their package. @Nocturnhabeo if you want to file an issue there this might get it fixed quicker for you (and others) on 2.3.1

@krader1961 krader1961 removed this from the fish 2.4.0 milestone Mar 25, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants