begin-selection: including extra character in selection #3684

Closed
daleeidd opened this Issue Dec 29, 2016 · 3 comments

Comments

Projects
None yet
4 participants
@daleeidd
Contributor

daleeidd commented Dec 29, 2016

  • Have you checked if problem occurs with fish 2.4.0?
  • Tried fish without third-party customizations (check sh -c 'env HOME=$(mktemp -d) fish')?

fish version installed (fish --version):
fish, version 2.4.0

OS/terminal used:
macOS 10.12.*
iTerm2 3.*

The prompt selection is including an extra character (the one in front of the cursor).

Reproduction steps

  1. Setup:
function fish_user_key_bindings
  bind \ce begin-selection
  bind \cr kill-selection
end
  1. Place the cursor somewhere except the beginning or end:

testing

  1. control+e then left or right

  2. control+r

Results

After left:
testing-left
After left kill:
testing-left-del
After right:
testing-right
After right kill:
testing-right-del

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Dec 29, 2016

Member

nice find

Member

ridiculousfish commented Dec 29, 2016

nice find

@daleeidd

This comment has been minimized.

Show comment
Hide comment
@daleeidd

daleeidd Dec 29, 2016

Contributor

@ridiculousfish Thanks. I see you have applied a vi-mode label. I just want to note that I am not using vi-mode.

Contributor

daleeidd commented Dec 29, 2016

@ridiculousfish Thanks. I see you have applied a vi-mode label. I just want to note that I am not using vi-mode.

@ridiculousfish ridiculousfish removed the vi-mode label Dec 30, 2016

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Dec 30, 2016

Member

Thanks, I removed the label

Member

ridiculousfish commented Dec 30, 2016

Thanks, I removed the label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment