Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

begin-selection: including extra character in selection #3684

Closed
daleeidd opened this issue Dec 29, 2016 · 3 comments
Closed

begin-selection: including extra character in selection #3684

daleeidd opened this issue Dec 29, 2016 · 3 comments
Milestone

Comments

@daleeidd
Copy link
Contributor

@daleeidd daleeidd commented Dec 29, 2016

  • Have you checked if problem occurs with fish 2.4.0?
  • Tried fish without third-party customizations (check sh -c 'env HOME=$(mktemp -d) fish')?

fish version installed (fish --version):
fish, version 2.4.0

OS/terminal used:
macOS 10.12.*
iTerm2 3.*

The prompt selection is including an extra character (the one in front of the cursor).

Reproduction steps

  1. Setup:
function fish_user_key_bindings
  bind \ce begin-selection
  bind \cr kill-selection
end
  1. Place the cursor somewhere except the beginning or end:

testing

  1. control+e then left or right

  2. control+r

Results

After left:
testing-left
After left kill:
testing-left-del
After right:
testing-right
After right kill:
testing-right-del

@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Dec 29, 2016

nice find

@daleeidd
Copy link
Contributor Author

@daleeidd daleeidd commented Dec 29, 2016

@ridiculousfish Thanks. I see you have applied a vi-mode label. I just want to note that I am not using vi-mode.

@ridiculousfish ridiculousfish removed the vi-mode label Dec 30, 2016
@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Dec 30, 2016

Thanks, I removed the label

@krader1961 krader1961 closed this in 7b90613 Jan 1, 2017
@krader1961 krader1961 modified the milestones: fish 2.5.0, fish-future Jan 2, 2017
@faho faho added the release notes label Jan 3, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.