New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tab completion glitch with multiline prompts #3693

Closed
nhooyr opened this Issue Jan 2, 2017 · 6 comments

Comments

Projects
None yet
4 participants
@nhooyr
Copy link
Contributor

nhooyr commented Jan 2, 2017

  • Have you checked if problem occurs with fish 2.4.0?
  • Tried fish without third-party customizations (check sh -c 'env HOME=$(mktemp -d) fish')?

fish version installed (fish --version): 2.3.1

OS/terminal used: macOS 10.12.2, iTerm2 3.0.13

  1. sh -c 'env HOME=$(mktemp -d) fish'
  2. funced fish_prompt
  3. Append echo -e \n at the end of the function
  4. Type some gibberish into the command like dsaiojadsiojdsiaolzmxnwiewrti, make sure it is enough text so that it extends past the prompt above.

screen shot 2017-01-02 at 3 33 14 pm

  1. Press tab to complete.

screen shot 2017-01-02 at 3 33 25 pm

if the prompt is single lined, the above glitch does not occur.

@ridiculousfish ridiculousfish added the bug label Jan 3, 2017

@ridiculousfish ridiculousfish added this to the fish-future milestone Jan 3, 2017

@ridiculousfish

This comment has been minimized.

Copy link
Member

ridiculousfish commented Jan 3, 2017

nice find

@nhooyr

This comment has been minimized.

Copy link
Contributor

nhooyr commented Jan 3, 2017

Also, it's using fish_color_search_match to highlight.

@ThomasAH

This comment has been minimized.

Copy link

ThomasAH commented Sep 8, 2017

I can't reproduce this in fish 2.6.
@nhooyr, do you still have this problem?

The only time I can see something similar is when entering long gibberish and pressing Ctrl-C.

Edit: the problem with Ctrl-C already has a separate issue: #3537

@nhooyr

This comment has been minimized.

Copy link
Contributor

nhooyr commented Sep 8, 2017

Can still reproduce fine on 2.6.0

@equal-l2

This comment has been minimized.

Copy link
Contributor

equal-l2 commented Sep 16, 2018

Any news here?
I can still reproduce this with fish 2.7.1 (and master) on iTerm2 and Terminal.app.

@ridiculousfish

This comment has been minimized.

Copy link
Member

ridiculousfish commented Sep 16, 2018

Fixed in e6863a9 . Thanks for filing!

@ridiculousfish ridiculousfish modified the milestones: fish-future, fish-3.0 Sep 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment