Support fish_vi_cursor on iTerm2

[nhooyr]

• Have you checked if problem occurs with fish 2.4.0?
• Tried fish without third-party customizations (check sh -c 'env HOME=$(mktemp -d) fish')?

fish version installed (fish --version): latest master, more specifically, 89e48ba

OS/terminal used: macOS 10.12.2 and iTerm 3.0.13

Watch: https://asciinema.org/a/152yxzpdz3m9igtqz8q5ags4x

[nhooyr]

manually executing __fish_cursor_1337 works fine and changes the cursor shape.

[faho]

Yes. The issue here is our detection uses tput Ss, and that particular definition isn't included in the macOS "xterm" terminfo.

I've got a fix in the pipeline but it needs a whole bunch more testing - this stuff is gnarly.

[faho]

@nhooyr: Please check my cursor-again branch.

[nhooyr]

works!

[nhooyr]

@faho though now I am getting #3481

[nhooyr]

Except, I noticed that pressing A (move to the end of the line and enter insert mode from normal mode) also reproduces the bug.

[nhooyr]

@faho and the cursor should begin blinking when entering insert mode. it doesn't do that

[faho]

the cursor should begin blinking when entering insert mode. it doesn't do that

@nhooyr: We don't have blinking enabled anywhere currently. IIRC it's a different argument to the sequence (e.g. 3 instead of 2 for blinking line and 5 instead of 4 for blinking block or something like that).

[faho]

Oh no, sorry. The xterm sequence supports blink, our iTerm and konsole functions (the sequences are nearly the same) currently don't. I'd have to look up what they use.

[faho]

I actually can't find documentation on this - the iterm proprietary escapes list doesn't have anything on it, and I can't find documentations for konsole. So it seems that these terminals don't actually support this.

Anyway, that's a different issue. This one is about us not changing the cursor in iTerm, which is currently blocking on #3481.

[tbodt]

Will this be fixed anytime soon?

[ridiculousfish]

Doesn't seem like anyone is actively working on it.