New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git tab completion missing a lot of options for 'git log' #3743

Closed
adymitruk opened this Issue Jan 18, 2017 · 7 comments

Comments

Projects
None yet
6 participants
@adymitruk
Contributor

adymitruk commented Jan 18, 2017

Some of the more common tab completions is git log do not appear.

Reproduce:
enter "git log --" and hit tab a couple of times. You only get 3 options.

Doing the same thing in bash gets you 100 options.

Some of the more common ones missing are: graph decorate oneline

@faho

This comment has been minimized.

Show comment
Hide comment
@faho

faho Jan 19, 2017

Member

As you already know, this just hasn't been written yet.

I'd appreciate a PR that includes these options (and possibly some for other git subcommands), ideally with hand-written (i.e. not just copied from the git man pages, since those are often inscrutable) descriptions.

Member

faho commented Jan 19, 2017

As you already know, this just hasn't been written yet.

I'd appreciate a PR that includes these options (and possibly some for other git subcommands), ideally with hand-written (i.e. not just copied from the git man pages, since those are often inscrutable) descriptions.

@moverest

This comment has been minimized.

Show comment
Hide comment
@moverest

moverest Jan 20, 2017

Contributor

I think we can do some other improvements as well. On top of my head:

Fish completes:

git push origin --s<tab>
git push origin --set-upstream-to

But set-upstream-to doesn't exist; set-upstream does (on git 2.11 AFAIK).

git push origin --delete some<tab>
git push origin --delete origin/some-branch

But git expects some-branch and not origin/some-branch.

I'll do a PR within a few days with git log options if I have time to do it.

Contributor

moverest commented Jan 20, 2017

I think we can do some other improvements as well. On top of my head:

Fish completes:

git push origin --s<tab>
git push origin --set-upstream-to

But set-upstream-to doesn't exist; set-upstream does (on git 2.11 AFAIK).

git push origin --delete some<tab>
git push origin --delete origin/some-branch

But git expects some-branch and not origin/some-branch.

I'll do a PR within a few days with git log options if I have time to do it.

@faho

This comment has been minimized.

Show comment
Hide comment
@faho

faho Jan 20, 2017

Member

But set-upstream-to doesn't exist; set-upstream does (on git 2.11 AFAIK).

See 96a28df. Now, apparently this was a misunderstanding - set-upstream-to is only for git branch, where set-upstream was deprecated in git 1.8. git pull still uses set-upstream, and doesn't have set-upstream-to at all.

That's git for ya.

Member

faho commented Jan 20, 2017

But set-upstream-to doesn't exist; set-upstream does (on git 2.11 AFAIK).

See 96a28df. Now, apparently this was a misunderstanding - set-upstream-to is only for git branch, where set-upstream was deprecated in git 1.8. git pull still uses set-upstream, and doesn't have set-upstream-to at all.

That's git for ya.

@faho faho added this to the fish-future milestone Jan 20, 2017

@moverest

This comment has been minimized.

Show comment
Hide comment
@moverest

moverest Jan 20, 2017

Contributor

They sure do know how to make things confusing. :-/

Contributor

moverest commented Jan 20, 2017

They sure do know how to make things confusing. :-/

@cprieto

This comment has been minimized.

Show comment
Hide comment
@cprieto

cprieto Jan 24, 2017

Contributor

I just finished with some fixing for the bzr completion and I can take a look at this now that I warmed up :) is ok @faho and @moverest ?

Contributor

cprieto commented Jan 24, 2017

I just finished with some fixing for the bzr completion and I can take a look at this now that I warmed up :) is ok @faho and @moverest ?

@moverest

This comment has been minimized.

Show comment
Hide comment
@moverest

moverest Jan 24, 2017

Contributor

I have a half baked fix. If you want to finish it, go ahead. :-)

https://gist.github.com/moverest/f72e73df809ef4aad0a8e90200d9ee07

Contributor

moverest commented Jan 24, 2017

I have a half baked fix. If you want to finish it, go ahead. :-)

https://gist.github.com/moverest/f72e73df809ef4aad0a8e90200d9ee07

@faho

This comment has been minimized.

Show comment
Hide comment
@faho

faho Jan 24, 2017

Member

All yours, @cprieto!

Member

faho commented Jan 24, 2017

All yours, @cprieto!

@cprieto cprieto referenced this issue Jan 27, 2017

Merged

Add more options for git log #3785

2 of 2 tasks complete

@faho faho closed this in #3785 Jan 27, 2017

faho added a commit that referenced this issue Jan 27, 2017

@zanchey zanchey modified the milestones: 2.6.0, fish-future Feb 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment