Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

vi binding 'e' has wrong behaviour on second-to-last char #4025

Open
Ambrevar opened this Issue May 13, 2017 · 1 comment

Comments

Projects
None yet
4 participants
Contributor

Ambrevar commented May 13, 2017

  • fish, version 2.5.0-384-g9e64571d
  • OS: Arch Linux
  • Term: Urxvt 9.22

Using vi bindings, if the cursor is on 1 in

12 345

pressing e in normal mode will move to 5 while it should move to 2.

The current definition of e is

bind e forward-char forward-word backward-char

I believe the following binding to be correct:

bind e forward-word backward-char

@zanchey zanchey added the vi-mode label May 13, 2017

Member

faho commented May 13, 2017

This was added to fix #2171.

I believe the following binding to be correct:

bind e forward-word backward-char

That binding has the issue that it will get stuck on "bigwords". E.g. executing it multiple times on "12-345" will have the cursor go to "2", then "-" and then get stuck there.

We probably need to introduce additional bind functions here - "end-of-word" and "beginning-of-word".

@krader1961 krader1961 added this to the fish-future milestone May 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment