New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento completions from magento.fish gives syntax error #4108

Closed
kozie opened this Issue Jun 7, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@kozie

kozie commented Jun 7, 2017

Fish version 2.6.0

Darwin kees.local 16.6.0 Darwin Kernel Version 16.6.0: Fri Apr 14 16:21:16 PDT 2017; root:xnu-3789.60.24~6/RELEASE_X86_64 x86_64 i386 MacBookPro12,1 Darwin

I haven't tried disabling third party tools but don't have much besides fisherman with below plugins and don't think any of these produces the below error since it's also a new (2.6.0) addition
* pure
await
fzf
get
getopts
last_job_id
z

When i'm in a magento 2 root folder and start typing something like bin/magento c the following error comes up. The last two double-quotes seemed to give the errors so i replaced them with the normal double quotes but the error remains.

/usr/local/Cellar/fish/2.6.0/share/fish/completions/magento.fish (line 621): Unexpected end of string, quotes are not balanced
__fish_magento_register_command_option theme:uninstall -f -s c -l clear-static-content -d "Clear generated static view files";
                                                                                                                            ^
from sourcing file /usr/local/Cellar/fish/2.6.0/share/fish/completions/magento.fish
        called on standard input

in command substitution
        called on standard input

source: Error while reading file '/usr/local/Cellar/fish/2.6.0/share/fish/completions/magento.fish'

@faho faho added the bug label Jun 7, 2017

@faho faho closed this in edaef4e Jun 7, 2017

@faho faho added the completions label Jun 7, 2017

@faho faho added this to the fish 2.7.0 milestone Jun 7, 2017

@faho

This comment has been minimized.

Show comment
Hide comment
@faho

faho Jun 7, 2017

Member

Thanks for reporting, and hooray for syntax highlighting!

Member

faho commented Jun 7, 2017

Thanks for reporting, and hooray for syntax highlighting!

@kozie

This comment has been minimized.

Show comment
Hide comment
@kozie

kozie Jun 7, 2017

Yeah, indeed! :) Thanks for the quick fix. I'll merge the file manually for now :)

kozie commented Jun 7, 2017

Yeah, indeed! :) Thanks for the quick fix. I'll merge the file manually for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment