You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bummer. This seems like a very useful fix. In my new fish article at https://mvolkmann.github.io/fish-article/#Colors (see "To enable the use of") I had to go into quite a bit of detail and include several links to explain how to fix this on a Mac. It would be great if none of that was necessary.
I agree, and eventually it will not be. @zanchey isn't the bad guy here!
I don't want to speak for him, but I think what he was referring to with the "not take this for now" thing is us not taking this for 2.7.0 for now - as it was milestoned - 2.7b1 is being rolled as we speak as a first beta. I'd have liked to see this fixed for 2.7 - I'd like to see it in a 2.7 beta - that's not in the cards - but regardless it remains fixed in our 3.0/master branch and I don't predict anyone reverting that so this is on a slow boat towards making it to everyone. (I'd perhaps like to see this make it into a 2.7.1 if one ever exists just because it's a TERRIBLY annoying broken feature on macOS, but no promises as that'd really need buy-in from other developers.)
And the one who reverted this patch from the 2.7 integration branch was me - I had cherry-picked it from 3.0 but some changes made since the source diverged caused it not to work so I immediately reverted it. One would need to re-do the patch for 2.7 to get the same behavior and functional italics/dim. Had I been quicker about coming up with a 2.7-specific patch it's possible I might have been able to sneak this fix in for 2.7.