Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace read -i with read -s #4490

Closed
mqudsi opened this issue Oct 18, 2017 · 4 comments
Closed

Replace read -i with read -s #4490

mqudsi opened this issue Oct 18, 2017 · 4 comments
Labels
Milestone

Comments

@mqudsi
Copy link
Contributor

@mqudsi mqudsi commented Oct 18, 2017

read's support for --silent came late in the game and -s was already being used for --shell.

How does everyone feel about making -s for --silent/--secure similar to bash and others, and changing --shell to something else? It seems the only place read -s is currently used in our code is just in funced.fish.

@mqudsi mqudsi added this to the fish-3.0 milestone Oct 18, 2017
@mqudsi mqudsi added the RFC label Oct 18, 2017
@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Oct 19, 2017

This makes sense to me. Maybe -i/--interactive for the existing --shell behavior.

@faho
Copy link
Member

@faho faho commented Oct 19, 2017

-i sounds nice, but if we used something else, we could add it to 2.7.0 for a nicer upgrade path in case anyone uses --shell.

So just -S for --shell?

@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Oct 22, 2017

I like the -S/--shell idea.

@cben
Copy link
Contributor

@cben cben commented Dec 17, 2017

another option is leave --shell without a short option.

@mqudsi mqudsi closed this in db8ec59 Mar 9, 2018
mqudsi added a commit that referenced this issue Mar 9, 2018
Change short option for `--shell` to `-S` per #4490 and add description for -s/--silent
mqudsi added a commit that referenced this issue Mar 9, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants