iTerm2 does not set fish_title correctly for tabs #47

Closed
ridiculousfish opened this Issue Jun 6, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@ridiculousfish
Member

ridiculousfish commented Jun 6, 2012

fish_title applies correctly to the window title, but not the tab title. This is due to this code in reader.cpp:

writestr( L"\x1b]2;" );

2: Window title
1: Tab title
0: Both window and tab title

I think removing the 2 is equivalent to setting it to 0, so that's probably what we ought to do.

@rdeits

This comment has been minimized.

Show comment
Hide comment
@rdeits

rdeits Jun 7, 2012

Contributor

Confirmed--removing the 2 causes both the window and tab titles to be set. I've created a pull request: https://github.com/ridiculousfish/fishfish/pull/58

Thanks for your help!

Contributor

rdeits commented Jun 7, 2012

Confirmed--removing the 2 causes both the window and tab titles to be set. I've created a pull request: https://github.com/ridiculousfish/fishfish/pull/58

Thanks for your help!

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Jun 12, 2012

Member

#58 was merged.
Thanks for this report.

Member

ridiculousfish commented Jun 12, 2012

#58 was merged.
Thanks for this report.

ridiculousfish added a commit that referenced this issue Jun 21, 2012

Fixes title update in tmux and screen
	* Seems that writestr( L"\x1b];" ); doesn't work in tmux and
	  screen. As discussed in fish-shell/fish-shell#47 the 2 was
	  removed. This commit adds the zero (L"\x1b]0;").
	* Tested in screen,tmux,iTerm and xterm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment