Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward-bigword command misbehaving with autosuggestions #5336

Closed
zx8 opened this issue Nov 13, 2018 · 1 comment
Closed

forward-bigword command misbehaving with autosuggestions #5336

zx8 opened this issue Nov 13, 2018 · 1 comment

Comments

@zx8
Copy link

@zx8 zx8 commented Nov 13, 2018

$ fish --version
fish, version 2.7.1-1680-g7257c699

I have the following keybindings set up:

alt+right  : forward-word
ctrl+right : forward-bigword

They work correctly for regular commandline arguments, however the forward-bigword keybinding acts as forward-word when used with autosuggestions, i.e. in the following screenshot, when pressing the forward-bigword keybind, I'd expect the cursor to be moved to the right of the letter j:

image

But instead it behaves as forward-word and moves to the right of the letter e.

@faho
Copy link
Member

@faho faho commented Nov 13, 2018

Yup. The issue here is that "accept_autosuggestion" (in reader.cpp) only takes a bool to decide if it should accept all of the suggestion, or only one word.

Instead, it should probably get the move_word_style, like the actual movement in the "active" commandline does.

@faho faho added this to the fish-future milestone Nov 13, 2018
@zanchey zanchey removed this from the fish-future milestone Feb 21, 2019
@zanchey zanchey added this to the fish 3.1.0 milestone Feb 21, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants