Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nim prompt on mac does not work #5490

Closed
gudstrand opened this Issue Jan 7, 2019 · 2 comments

Comments

Projects
None yet
4 participants
@gudstrand
Copy link

gudstrand commented Jan 7, 2019

version 3.0.0
Darwin saturn 18.2.0 Darwin Kernel Version 18.2.0: Mon Nov 12 20:24:46 PST 2018; root:xnu-4903.231.4~2/RELEASE_X86_64 x86_64
xterm-256color

  1. new installation of fish via brew
  2. added fish to /etc/shells
  3. ran fish
  4. ran fish_config
  5. went to prompt and selected Nim and clicked on set prompt

when I now do an ls I see the following:
┬─[gudstrand@saturn:~/.c/fish]
╰─>$ ls
config.fish fish_variables functions
fish: Unknown command '_nim_prompt_wrapper'
~/.config/fish/functions/fish_prompt.fish (line 29):
_nim_prompt_wrapper $retc '' (date +%X)
^
in function 'fish_prompt'
called on standard input

in command substitution
called on standard input

┬─[gudstrand@saturn:~/.c/fish]
╰─>$

nim.prompt.txt

@faho faho closed this in d4be5f0 Jan 7, 2019

@faho faho added the bug label Jan 7, 2019

@faho faho added this to the fish 3.1.0 milestone Jan 7, 2019

@faho

This comment has been minimized.

Copy link
Member

faho commented Jan 7, 2019

Sorry about that!

This is a manifestation of #736, which we should get around to fixing. I've applied a workaround for now, so it should work in the next release.

For now, instead of choosing it via fish_config, copy the file with something like

cp $__fish_data_dir/tools/web_config/sample_prompts/nim.fish $fish_function_path[1]/fish_prompt.fish

@zanchey zanchey modified the milestones: fish 3.1.0, fish 3.0.1 Jan 18, 2019

ridiculousfish added a commit that referenced this issue Jan 22, 2019

Fix nim prompt (via web_config)
This had a helper function defined outside of the fish_prompt
function, so `funcsave` missed it (see #736).

Fixes #5490.

[ci skip]
@ridiculousfish

This comment has been minimized.

Copy link
Member

ridiculousfish commented Jan 22, 2019

Picked into 3.0.1 as 96f7924

eatradish pushed a commit to AOSC-Dev/aosc-os-abbs that referenced this issue Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.