New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completing files inside quotes adds the result outside of quotes #552

Closed
lledey opened this Issue Jan 30, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@lledey
Contributor

lledey commented Jan 30, 2013

Hitting tab when writing inside quotes results in completing files outside of the quotes.

Example:
...> touch test
...> echo "te<tab>"
...> echo "te"st

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Jan 30, 2013

Member

Good find. The key is that you have to be inside the closing quote.

Member

ridiculousfish commented Jan 30, 2013

Good find. The key is that you have to be inside the closing quote.

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Feb 2, 2013

Member

Fixed as ded81ec . Now fish will try to appropriate a closing quote in completions, even if the cursor is outside of them.

echo "te<tab>" -> echo "test"
echo "te"<tab> -> echo "test"
Member

ridiculousfish commented Feb 2, 2013

Fixed as ded81ec . Now fish will try to appropriate a closing quote in completions, even if the cursor is outside of them.

echo "te<tab>" -> echo "test"
echo "te"<tab> -> echo "test"
@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Feb 2, 2013

Member

Thanks for reporting this

Member

ridiculousfish commented Feb 2, 2013

Thanks for reporting this

@lledey

This comment has been minimized.

Show comment
Hide comment
@lledey

lledey Feb 2, 2013

Contributor

Nice, thanks !

Contributor

lledey commented Feb 2, 2013

Nice, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment