Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish 3.0.1? #5520

Closed
zanchey opened this Issue Jan 12, 2019 · 11 comments

Comments

Projects
None yet
7 participants
@zanchey
Copy link
Member

commented Jan 12, 2019

I'm asking for opinions on whether to put out a 3.0.1 to fix showstopping bugs following 3.0.0, and what to include. I would be aiming to get it out this month. Otherwise they will have to wait for 3.1.0, which I've got planned for March or so.

Candidates include:

  • #5449 (regression)
  • #5426 (build failure on Cygwin)
  • #5438 (regression)
  • #5519 (regression, unfixed as of this writing)
  • #5453 (possibly - memory corruption, hit in the tests, could conceivably be hit in production)
  • #5458 (possibly - failure on OpenIndiana)
  • #5479 (memory corruption segfault, hit in the tests, could conceivably be hit in production)

@zanchey zanchey self-assigned this Jan 12, 2019

@zanchey zanchey added the RFC label Jan 12, 2019

@mqudsi

This comment has been minimized.

Copy link
Contributor

commented Jan 12, 2019

I think the OpenIndiana folks are doing a fine job incorporating patches and updates post 3.0, so #5458 isn't very important. The others all sound worth including.

@cdluminate

This comment has been minimized.

Copy link
Contributor

commented Jan 12, 2019

I (Debian developer maintaining fish) second the request for the 3.0.1 release. We are reaching the freezing stage of the next stable release (aka. Debian Buster) [1]. And the timing of 3.1.0 release sounds too late for Debian Buster. So I think releasing 3.0.1 would make great sense.

[1] https://release.debian.org/

@faho

This comment has been minimized.

Copy link
Member

commented Jan 12, 2019

I'm all for doing a bugfix release!

The question is always how big we want it to be?

I would say anything from https://github.com/fish-shell/fish-shell/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aclosed+milestone%3A%22fish+3.1.0%22+ is a candidate here.

Some things I think should be included:

  • #5481 is a regression and an easy fix

  • #5447, at least a7998c4 is a performance regression fixed by removing an assert.

And some maybes:

  • #5476, given that it's been reported twice. It's more of a matter of taste, though.

  • #5513 would be nice to include, if we can get it fixed in a timely manner

  • #5456 would be nice to have, if we can come up with an answer for it. It's slightly larger, though.

@floam

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

Yes, I think we should, there are a few real stinkers that would be nice to get out of the way so we can focus on having time to do a nice 3.1.

@mqudsi

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2019

I personally view #5513 as worthy of a 3.0.1 all on its own, but maybe that's just me.

@drupol

This comment was marked as resolved.

Copy link

commented Jan 16, 2019

Please fix the Freebsd issue.

@faho faho added this to the fish 3.0.1 milestone Jan 17, 2019

@ridiculousfish

This comment has been minimized.

Copy link
Member

commented Jan 19, 2019

I've got two weeks free, I can definitely do this.

@ridiculousfish

This comment has been minimized.

Copy link
Member

commented Jan 20, 2019

master has diverged too far so 3.0.1 should be based on 3.0.0. I've added an Integration_3.0.1 branch to origin, let's fix the 3.0.1 issues in master, and cherry-pick into Integration_3.0.1.

@zanchey zanchey removed the RFC label Jan 26, 2019

@ridiculousfish

This comment has been minimized.

Copy link
Member

commented Jan 28, 2019

Milestone is complete, let's do it!

@faho faho added the packaging label Jan 28, 2019

@zanchey

This comment has been minimized.

Copy link
Member Author

commented Jan 29, 2019

Awesome - well done. I should have time to roll the release in the next week or so (perhaps even tonight).

@ridiculousfish

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

Thanks everyone for the hard and timely work here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.