Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish 3.0 in ssh session has some git bugs. #5578

Closed
latiaoxia opened this Issue Jan 24, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@latiaoxia
Copy link

latiaoxia commented Jan 24, 2019

fish, version 3.0.0
server OS: 4.8.0-36-generic #36~16.04.1-Ubuntu SMP

When I ssh login ubuntu server to fish, in the git repo, typing git add .<tab> will cause some wrong matches:

~> git add .<tab>
../../../.cache/  (Untracked file)  ../../../.config/  (Untracked file)  :/.cmake/   (Untracked file)
../../../.cmake/  (Untracked file)  :/.cache/          (Untracked file)  :/.config/  (Untracked file)

../../../* are the wrong matches.

And fish in local linux os does not have such issue, only in remote ssh login session.

@faho

This comment has been minimized.

Copy link
Member

faho commented Jan 24, 2019

The issue is that your remote git is old and doesn't support status --porcelain=2, so we fall back to the v1 format, which doesn't give us relative paths, so we have to compute them ourselves (which is a right PITA).

The code that did that had a bug if you're in the git root (where it should have done nothing).

I've fixed this, incidentally, in 4af2a68. Which will be in the upcoming 3.0.1 release.

@faho faho closed this Jan 24, 2019

@faho faho added this to the fish 3.0.1 milestone Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.