Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect tab-completion escaping with certain characters #5831

Closed
zx8 opened this issue Apr 19, 2019 · 1 comment
Closed

Incorrect tab-completion escaping with certain characters #5831

zx8 opened this issue Apr 19, 2019 · 1 comment
Labels
bug
Milestone
fish 3.1.0

Comments

@zx8
Copy link

@zx8 zx8 commented Apr 19, 2019 

$ fish --version
fish, version 3.0.2-948-g4ddfd730

Repro:

$ touch foo foo[bar]
$ ls foo[<TAB>
$ ls foo[bar\]

This should have completed to either foo[bar] or foo\[bar\], but not foo[bar\]:

image
@zx8 zx8 changed the title Incorrect tab-completion escaping after manual input Incorrect tab-completion escaping with certain characters Apr 19, 2019
@faho faho added the bug label May 24, 2019
@faho faho added this to the fish 3.1.0 milestone May 24, 2019
krobelus added a commit to krobelus/fish-shell that referenced this issue Aug 24, 2019
@krobelus
escape unclosed brackets in a token before completing it
7bb1901 
fixes fish-shell#5831
@krobelus krobelus mentioned this issue Aug 24, 2019
Closed
3 tasks
krobelus added a commit to krobelus/fish-shell that referenced this issue Sep 4, 2019
@krobelus
escape unclosed brackets in an argument before completing it
88f5218 
fixes fish-shell#5831
krobelus added a commit to krobelus/fish-shell that referenced this issue Sep 4, 2019
@krobelus
escape square brackets in an argument before completing it
b56aa27 
fixes fish-shell#5831
@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Sep 8, 2019 •
edited

I like the new approach better too! Merged as bc3dde9 . Thank you!!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
fish 3.1.0
Development

No branches or pull requests
3 participants
@ridiculousfish @faho @zx8