Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error message references "array" not "list" #5846

Closed
danielb2 opened this issue Apr 26, 2019 · 7 comments
Closed

error message references "array" not "list" #5846

danielb2 opened this issue Apr 26, 2019 · 7 comments
Labels
docs RFC
Milestone

Comments

@danielb2
Copy link
Contributor

@danielb2 danielb2 commented Apr 26, 2019

fish, version 3.0.2

$ echo $PATH[0]
fish: array indices start at 1, not 0.

to be consistent with documentation, the error message should read list indices start at 1, not 0

@faho
Copy link
Member

@faho faho commented Apr 26, 2019

to be consistent with documentation

https://github.com/fish-shell/fish-shell/blob/master/sphinx_doc_src/index.rst#arrays exists.

I'm not sure we want to always talk about "lists", because "array" is a well-known term as well.

@faho faho added docs RFC labels Apr 26, 2019
@danielb2
Copy link
Contributor Author

@danielb2 danielb2 commented Apr 26, 2019

Would it be prudent then to switch out all references to just say array instead of list? I'm weary of using one terminology in one place, and another in another. It creates confusion

@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Apr 30, 2019

Yes, please do a PR to make this consistent. I like "list" slightly more because it's shorter but no strong opinions.

@zanchey
Copy link
Member

@zanchey zanchey commented Apr 30, 2019

List is a better term for non-programmers.

@faho
Copy link
Member

@faho faho commented May 5, 2019

Okay, closed. I decided to mention the term "array" (and keep a bit where we say Other shells use the term "arrays"), and it's still read --array (altering that would have been a bit embarassing).

@faho faho added this to the fish 3.1.0 milestone May 5, 2019
@zanchey
Copy link
Member

@zanchey zanchey commented May 6, 2019

Should we add --list as a synonym?

zanchey added a commit that referenced this issue Aug 22, 2019
@zanchey
Copy link
Member

@zanchey zanchey commented Aug 22, 2019

Done in 225b120

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs RFC
Projects
None yet
Development

No branches or pull requests

4 participants